You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump useragent to 2.3.0 to pull in ua-parser/uap-core#263 in which Headless Chrome version detected to be 0.0.0.
Update tests to reflect latest useragent OS major version string identifiers.
Per ua-parser/uap-core#286 , useragent purposely sets the Windows Vista family to Windows and major version to Vista. The change to useragent was intentional, and the maintainer advises upstream consumers to update tests to reflect the change.
Per 3rd-Eden/useragent#120 , there is an open question to change the stringified OS to not include 0 for missing version numbers. For example:
would display as "Windows Vista" instead of "Windows Vista.0.0".
That open question not withstanding, this commit is an incremental improvement: You can now see both Chrome Headless version and Windows version information in your console output. In general, useragentconsumers that perform int() conversions on 'major' should be aware.
AFAIK Karma used to use a newer useragent version but reverted to an older one to avoid the Vista.0.0 issue but not showing a Chrome (even if only headless) version at all seems worse than this purely visual issue.
Please don't close this PR, though, as you did with #3199 & #3200 as that only splits the discussion and makes changes hard to follow. Instead, amend the commit and push via:
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
useragent
to2.3.0
to pull in ua-parser/uap-core#263 in which Headless Chrome version detected to be0.0.0
.Update tests to reflect latest
useragent
OS major version string identifiers.Per ua-parser/uap-core#286 ,
useragent
purposely sets the Windows Vistafamily
toWindows
andmajor
version toVista
. The change touseragent
was intentional, and the maintainer advises upstream consumers to update tests to reflect the change.Per 3rd-Eden/useragent#120 , there is an open question to change the stringified OS to not include
0
for missing version numbers. For example:would display as
"Windows Vista"
instead of"Windows Vista.0.0"
.That open question not withstanding, this commit is an incremental improvement: You can now see both Chrome Headless version and Windows version information in your console output. In general,
useragent
consumers that performint()
conversions on'major'
should be aware.Fixes #2762