feat: refine function split

josdejong · josdejong · commit 8104582fe1c2 · 2024-12-02T15:53:49.000+01:00
diff --git a/README.md b/README.md
@@ -10,7 +10,7 @@ Try it out on the online playground: <https://jsonquerylang.org>
 
 ## Features
 
-- Small: just `3.2 kB` when minified and gzipped! The JSON query engine without parse/stringify is only `1.7 kB`.
+- Small: just `3.3 kB` when minified and gzipped! The JSON query engine without parse/stringify is only `1.7 kB`.
 - Feature rich (50+ powerful functions and operators)
 - Easy to interoperate with thanks to the intermediate JSON format.
 - Expressive
diff --git a/src/functions.ts b/src/functions.ts
@@ -206,10 +206,10 @@ export const functions: FunctionBuildersMap = {
     (data: T[]) =>
       data.join(separator),
 
-  split:
-    (separator = '') =>
-    (data: string) =>
-      data.split(separator as string),
+  split: (separator?: string) =>
+    separator !== undefined
+      ? (data: string) => data.split(separator)
+      : (data: string) => data.trim().split(/\s+/),
 
   substring: (start: number, end: number) => (data: string) => data.slice(Math.max(start, 0), end),
 
diff --git a/test-suite/compile.test.json b/test-suite/compile.test.json
@@ -1,6 +1,6 @@
 {
   "source": "https://github.com/jsonquerylang/jsonquery/tree/main/test-suite/compile.test.json",
-  "updated": "2024-11-29T11:00:00Z",
+  "updated": "2024-12-02T11:00:00Z",
   "tests": [
     {
       "category": "value",
@@ -506,16 +506,30 @@
     {
       "category": "split",
       "description": "should split a string",
-      "input": "abc",
+      "input": "start with a b c",
+      "query": ["split"],
+      "output": ["start", "with", "a", "b", "c"]
+    },
+    {
+      "category": "split",
+      "description": "should split a string with multiple whitespaces between the words",
+      "input": " \n\n\t start   with  a   b \n\r\t  c \n\n\t ",
       "query": ["split"],
+      "output": ["start", "with", "a", "b", "c"]
+    },
+    {
+      "category": "split",
+      "description": "should split a string by individual characters",
+      "input": "abc",
+      "query": ["split", ""],
       "output": ["a", "b", "c"]
     },
     {
       "category": "split",
       "description": "should split a string with a separator",
-      "input": "hi there how are you doing?",
-      "query": ["split", " "],
-      "output": ["hi", "there", "how", "are", "you", "doing?"]
+      "input": "a,b,c",
+      "query": ["split", ","],
+      "output": ["a", "b", "c"]
     },
 
     {
