fix: a minor performance improvement in parse

josdejong · josdejong · commit 7cea93ed3206 · 2024-11-15T14:41:23.000+01:00
diff --git a/src/parse.ts b/src/parse.ts
@@ -26,6 +26,9 @@ import type { JSONQuery, JSONQueryParseOptions } from './types'
  *     //  ]
  */
 export function parse(query: string, options?: JSONQueryParseOptions): JSONQuery {
+  const allOperators = { ...operators, ...options?.operators }
+  const sortedOperatorNames = Object.keys(allOperators).sort((a, b) => b.length - a.length)
+
   const parsePipe = () => {
     skipWhitespace()
     const first = parseOperator()
@@ -48,19 +51,18 @@ export function parse(query: string, options?: JSONQueryParseOptions): JSONQuery
   }
 
   const parseOperator = () => {
-    const allOperators = { ...operators, ...options?.operators }
 
-    const left = parseParentheses()
+    const left = parseParenthesis()
 
     skipWhitespace()
 
     // we sort the operators from longest to shortest, so we first handle "<=" and next "<"
-    for (const name of Object.keys(allOperators).sort((a, b) => b.length - a.length)) {
+    for (const name of sortedOperatorNames) {
       const op = allOperators[name]
       if (query.substring(i, i + op.length) === op) {
         i += op.length
         skipWhitespace()
-        const right = parseParentheses()
+        const right = parseParenthesis()
 
         return [name, left, right]
       }
@@ -69,7 +71,7 @@ export function parse(query: string, options?: JSONQueryParseOptions): JSONQuery
     return left
   }
 
-  const parseParentheses = () => {
+  const parseParenthesis = () => {
     if (query[i] === '(') {
       i++
       const inner = parsePipe()
@@ -81,9 +83,9 @@ export function parse(query: string, options?: JSONQueryParseOptions): JSONQuery
   }
 
   const parseProperty = () => {
-    const props = []
-
     if (query[i] === '.') {
+      const props = []
+
       while (query[i] === '.') {
         i++
 
diff --git a/src/stringify.ts b/src/stringify.ts
@@ -76,7 +76,7 @@ export const stringify = (query: JSONQuery, options?: JSONQueryStringifyOptions)
     const childIndent = args.length === 1 ? indent : indent + space
     const argsStr = args.map((arg) => _stringify(arg, childIndent))
     return args.length === 1 && argsStr[0][0] === '('
-      ? `${name}${argsStr}`
+      ? `${name}${argsStr[0]}`
       : join(
           argsStr,
           [`${name}(`, ', ', ')'],
