Dialog: Moved the default value for the position.of option inside the _position() method to avoid a bug in jQuery 1.3.2. Fixes #6030 - ui.dialog with jQuery 1.3.2 causes RangeError.

scottgonzalez · scottgonzalez · commit 22671ad4f8e3 · 2010-12-08T12:36:19.000-05:00
This should be reverted in jQuery UI 1.9.
diff --git a/tests/unit/dialog/dialog_defaults.js b/tests/unit/dialog/dialog_defaults.js
@@ -20,7 +20,6 @@ var dialog_defaults = {
 	position: {
 		my: 'center',
 		at: 'center',
-		of: window,
 		collision: 'fit',
 		using: $.ui.dialog.prototype.options.position.using
 	},
diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js
@@ -57,7 +57,6 @@ $.widget("ui.dialog", {
 		position: {
 			my: 'center',
 			at: 'center',
-			of: window,
 			collision: 'fit',
 			// ensure that the titlebar is never outside the document
 			using: function(pos) {
@@ -528,7 +527,7 @@ $.widget("ui.dialog", {
 		this.uiDialog
 			// workaround for jQuery bug #5781 https://dev.jquery.com/ticket/5781
 			.css({ top: 0, left: 0 })
-			.position(position);
+			.position($.extend({ of: window }, position));
 		if (!isVisible) {
 			this.uiDialog.hide();
 		}
