fix(issue-231): nil *Token pointer panic

ivanilves · ivanilves · commit 82034fe71cde · 2021-07-21T07:11:56.000+02:00
diff --git a/api/v1/registry/client/client.go b/api/v1/registry/client/client.go
@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"io"
 	"net/http"
+	"reflect"
 	"time"
 
 	log "github.com/sirupsen/logrus"
@@ -176,7 +177,7 @@ func decodeAllTagData(body io.ReadCloser) ([]string, map[string]manifest.Manifes
 }
 
 func (cli *RegistryClient) repoToken(repoPath string) (auth.Token, error) {
-	if cli.Token != nil && cli.Token.Method() != "Bearer" {
+	if cli.Token != nil && !reflect.ValueOf(cli.Token).IsNil() && cli.Token.Method() != "Bearer" {
 		return cli.Token, nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@ import (`
`6`	`6`	`"fmt"`
`7`	`7`	`"io"`
`8`	`8`	`"net/http"`
	`9`	`+ "reflect"`
`9`	`10`	`"time"`
`10`	`11`
`11`	`12`	`log "github.com/sirupsen/logrus"`
`@@ -176,7 +177,7 @@ func decodeAllTagData(body io.ReadCloser) ([]string, map[string]manifest.Manifes`
`176`	`177`	`}`
`177`	`178`
`178`	`179`	`func (cli *RegistryClient) repoToken(repoPath string) (auth.Token, error) {`
`179`		`- if cli.Token != nil && cli.Token.Method() != "Bearer" {`
	`180`	`+ if cli.Token != nil && !reflect.ValueOf(cli.Token).IsNil() && cli.Token.Method() != "Bearer" {`
`180`	`181`	`return cli.Token, nil`
`181`	`182`	`}`
`182`	`183`