| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 18 Jul 2025 19:48:32 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=341.704467,conversation_content-fragment;desc="conversation_content fragment";dur=645.380557,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=281.526074,nginx;desc="NGINX";dur=1.322982,glb;desc="GLB";dur=96.008865
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ntZLxm%2BvLE3Duo40PZI0ir6XOkwtWhbqwUjZVigsBjtE7zmFr86%2BJIAY9FjSGhB%2F3VWIcgyJrQffSNc4kYa2N1qin0qgwgYrSi5jQ210c%2F3DbhAFA0SJfRh0EOea0aiOHiyasg8sW3aWFhXelqkFDTIKgBVcwmQy0uc9OXmXHs83oQC0nDSHG9zadg6pijUSwzpwMgaT%2BhPCHU%2ByTeQ5KtlQ4GU2xbms2rg8dAcTNuVlYvkRhFMgmkzx%2BXgMkYWIxhHlNNBgQFMboLrP9VHLVA%3D%3D--aIEhZhX%2BYIW00BZo--AAA6cYYchS90QpIc4xAF7A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1656414685.1752868111; Path=/; Domain=github.com; Expires=Sat, 18 Jul 2026 19:48:31 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 18 Jul 2026 19:48:31 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CC4C:2DDAD2:11DAA6:16B660:687AA50F
Rename getPose arg referenceSpace->baseSpace by toji · Pull Request #659 · immersive-web/webxr · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 401
Rename getPose arg referenceSpace->baseSpace #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of `referenceSpace` here may inadvertently suggest that it only takes an `XRReferenceSpace` object, when in reality it can take any `XRSpace`. Using `baseSpace` as a replacement at the suggestion of @klausw and @thetuvix. Plus it's fun to say: `getPose` finds the place of your space in the baseSpace's space! ;D
Manishearth
approved these changes
May 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also should change reference->base in https://github.com/immersive-web/webxr/pull/654/files#diff-ec9cfa5f3f35ec1f84feb2e59686c34dR1132
|
Thanks for catching that! |
klausw
approved these changes
May 20, 2019
|
@NellWaliczek is the one that initially asked for this change, but is unavailable for reviews for the next few days. In the meantime I'd prefer to get this landed now under the assumption that it's less confusing than the previous verbiage. I'll happily take the blame if Nell takes issue with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though are any changes needed in the explainer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Addresses concerns raised after landing #654
The use of
referenceSpacehere may inadvertently suggest that it onlytakes an
XRReferenceSpaceobject, when in reality it can take anyXRSpace. UsingbaseSpaceas a replacement at the suggestion of@klausw and @thetuvix.
Plus it's fun to say:
getPosefinds the place of your space in thebaseSpace's space! 😉