| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 17 Jul 2025 17:22:40 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=258.747505,conversation_content-fragment;desc="conversation_content fragment";dur=930.808777,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=243.247578,nginx;desc="NGINX";dur=0.967142,glb;desc="GLB";dur=94.927149
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=7lhPB23rFDWUdUP68uCrQ5r2akF642iC1vlL%2BtSoGrZy2BNoSAlY%2F359OujuJ4jehw14E8aSyW0NXjMAuNp4eO6Lx6NWIfLXsoG6sKpegXsxvgcFD2Rcts1PPn2N9EQ7nNKU8WGgnzDohAkYoHlceEYXytOKd8KD5cLnL8Vby576zB5BT2N4rWQNURe3Q7LNuxX8XmYX0cUldE5PLNoeWvcAeqtu51FakI5odOjpohcjsphBtjgDEqmRsqxYzszryYC3KIUk5q4zfouavcEhDg%3D%3D--NF9VOJylS433Rsu9--B0wfwodTe5La7ZsRYCWIDQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2061881634.1752772959; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 17:22:39 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 17:22:39 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AC8C:16E104:399FF8:42DCB5:6879315F
Expose XRSession's granted features by alcooper91 · Pull Request #1296 · immersive-web/webxr · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 401
Expose XRSession's granted features #1296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alcooper91
merged 2 commits into
immersive-web:main
from
alcooper91:add_enabledFeatures
Aug 24, 2022
Merged
Expose XRSession's granted features #1296
alcooper91
merged 2 commits into
immersive-web:main
from
alcooper91:add_enabledFeatures
Aug 24, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribute to XRSession
|
I weighed adding a change event but opted not to at this time since we don't currently have any mechanisms/algorithm's/language about changing the set of enabled features mid session; but it should be fairly straightforward to add if we want to either pre-emptively add support, or if I just missed that. |
Manishearth
reviewed
Aug 16, 2022
Manishearth
approved these changes
Aug 17, 2022
toji
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for putting this together!
github-actions bot
added a commit
that referenced
this pull request
Aug 24, 2022
SHA: a493dd5 Reason: push, by @alcooper91 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 1, 2024
… type sequence<DOMString>. r=mccr8 This was changed in the spec here: immersive-web/webxr#1296 Differential Revision: https://phabricator.services.mozilla.com/D201336
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 2, 2024
… type sequence<DOMString>. r=mccr8 This was changed in the spec here: immersive-web/webxr#1296 Differential Revision: https://phabricator.services.mozilla.com/D201336
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 4, 2024
… type sequence<DOMString>. r=mccr8 This was changed in the spec here: immersive-web/webxr#1296 Differential Revision: https://phabricator.services.mozilla.com/D201336
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 4, 2024
… type sequence<DOMString>. r=mccr8 This was changed in the spec here: immersive-web/webxr#1296 Differential Revision: https://phabricator.services.mozilla.com/D201336
josephrocca
added a commit
to josephrocca/three.js
that referenced
this pull request
Mar 11, 2024
…sion.requestLightProbe` The double-negative here is unfortunate, but currently `session.enabledFeatures` is only available in Chromium-based browsers, so we can't always *positively* know that the feature is supported. Another approach would be to wrap `session.requestLightProbe` in try/catch, or add `.catch` after the `.then`, but for whatever reason, those don't seem to actually catch the error for me. Related: immersive-web/webxr#1296
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Per Issue #1205, this proposal makes the following changes:
enabledFeaturesNote that this second change is consistent with how feature descriptors have currently been extended by the various other specs. It essentially requires that we have a string representation of the feature and can then further configure the feature as needed.
Preview | Diff