fix: patching maps failed when using number keys (#1025)

schummar · web-flow · commit dd83e2e2db0c · 2023-03-23T17:36:02.000Z
diff --git a/__tests__/patch.js b/__tests__/patch.js
@@ -214,6 +214,24 @@ describe("simple assignment - 7", () => {
 	)
 })
 
+describe("simple assignment - 8", () => {
+	runPatchTest(
+		new Map([[0, new Map([[1, 4]])]]),
+		d => {
+			d.get(0).set(1, 5)
+			d.get(0).set(2, 6)
+		},
+		[
+			{op: "replace", path: [0, 1], value: 5},
+			{op: "add", path: [0, 2], value: 6}
+		],
+		[
+			{op: "replace", path: [0, 1], value: 4},
+			{op: "remove", path: [0, 2]}
+		]
+	)
+})
+
 describe("delete 1", () => {
 	runPatchTest(
 		{x: {y: 4}},
diff --git a/src/plugins/patches.ts b/src/plugins/patches.ts
@@ -207,7 +207,11 @@ export function enablePatches() {
 			let base: any = draft
 			for (let i = 0; i < path.length - 1; i++) {
 				const parentType = getArchtype(base)
-				const p = "" + path[i]
+				let p = path[i]
+				if (typeof p !== "string" && typeof p !== "number") {
+					p = "" + p
+				}
+
 				// See #738, avoid prototype pollution
 				if (
 					(parentType === Archtype.Object || parentType === Archtype.Array) &&
