Are the two scripts still necessary in the repo?

I only ask because for fellow users who want to install the plugin but want to have a quick check of the code, they might seem alarmed the fact there are .sh files in the repo.

If they are for development purposes, perhaps they could be added to either:

the .gitignore file, so they remain on your local machine but do not exist in the github repo, or
an .npmignore file, so the files won't exist when a user installs a plugin on their machine, but will appear in the github repo

This is an example of my .npmignore file, the files are still present in the github repo but just aren't published as part of the package that is uploaded to npm:
https://github.com/bwp91/homebridge-govee/blob/latest/.npmignore

I'm simply suggesting this because having .sh files is not typical in homebridge plugin repos, and im certainly not accusing you of any wrong-doing, but I personally don't like the idea of a verified plugin with these files present.

Another couple of things to hopefully save some back and forth!

(1) OPTIONAL:

Consider adding a name property here:
https://github.com/bombadiltom/homebridge-rademacher-homepilot/blob/ac9a88389fd5b63e7b30b558dfc52eb0d291e4d0/config.schema.json#L9

Just so that users can rename how the plugin looks in the homebridge log.

Like I do here:
https://github.com/bwp91/homebridge-govee/blob/c5157be2c468292bd907d89f767303a72afa456f/config.schema.json#L11

(2) OPTIONAL:

Don't forget to add some keywords here:
https://github.com/bombadiltom/homebridge-rademacher-homepilot/blob/ac9a88389fd5b63e7b30b558dfc52eb0d291e4d0/package.json#L6

So your plugin appears in the homebridge UI if for example a user searches "rademacher" instead of having to search "homebridge-rademacher-homepilot"

(3) OPTIONAL

Your config.json file is invalid json, you need to escape the quotes on this line:
https://github.com/bombadiltom/homebridge-rademacher-homepilot/blob/ac9a88389fd5b63e7b30b558dfc52eb0d291e4d0/config.json#L9
or even just replace them with single quotes '.

homebridge-rademacher-homepilot #569

Description

Link To GitHub Repo

Link To NPM Package

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions