Improve parse-properties-to-match scriptlet helper

gorhill · gorhill · commit 7494eaf621c6 · 2024-12-21T11:27:03.000-05:00
Related issue: uBlockOrigin/uBlock-discussions#831 (comment) If the property name contains unexpected characters, assume that the `:` is not a separator.
diff --git a/src/js/resources/scriptlets.js b/src/js/resources/scriptlets.js
@@ -598,8 +598,12 @@ function parsePropertiesToMatch(propsToMatch, implicit = '') {
     if ( propsToMatch === undefined || propsToMatch === '' ) { return needles; }
     const options = { canNegate: true };
     for ( const needle of safe.String_split.call(propsToMatch, /\s+/) ) {
-        const [ prop, pattern ] = safe.String_split.call(needle, ':');
+        let [ prop, pattern ] = safe.String_split.call(needle, ':');
         if ( prop === '' ) { continue; }
+        if ( pattern !== undefined && /[^$\w -]/.test(prop) ) {
+            prop = `${prop}:${pattern}`;
+            pattern = undefined;
+        }
         if ( pattern !== undefined ) {
             needles.set(prop, safe.initPattern(pattern, options));
         } else if ( implicit !== '' ) {
