fix(no-undefined-types): exempt global requires from undefined property checks; fixes #1425 (#1426)

brettz9 · web-flow · commit c51ee4fe5520 · 2025-07-07T17:03:20.000+08:00
diff --git a/docs/rules/no-undefined-types.md b/docs/rules/no-undefined-types.md
@@ -996,5 +996,13 @@ class SomeClass {
  *
  * @member {Intl.Collator}
  */
+
+const otherFile = require('./other-file');
+
+/**
+ * A function
+ * @param {otherFile.MyType} a
+ */
+function f(a) {}
 ````
 
diff --git a/src/rules/noUndefinedTypes.js b/src/rules/noUndefinedTypes.js
@@ -312,6 +312,19 @@ export default iterateJsdoc(({
                   return `${name}.${property}`;
                 }).filter(Boolean),
               ];
+            case 'VariableDeclarator':
+              if (/** @type {import('@typescript-eslint/types').TSESTree.Identifier} */ (
+                /** @type {import('@typescript-eslint/types').TSESTree.CallExpression} */ (
+                  globalItem?.init
+                )?.callee)?.name === 'require'
+              ) {
+                imports.push(/** @type {import('@typescript-eslint/types').TSESTree.Identifier} */ (
+                  globalItem.id
+                ).name);
+                break;
+              }
+
+              return [];
           }
 
           return [
diff --git a/test/rules/assertions/noUndefinedTypes.js b/test/rules/assertions/noUndefinedTypes.js
@@ -1729,5 +1729,16 @@ export default /** @type {import('../index.js').TestCases} */ ({
          */
       `,
     },
+    {
+      code: `
+        const otherFile = require('./other-file');
+
+        /**
+         * A function
+         * @param {otherFile.MyType} a
+         */
+        function f(a) {}
+      `,
+    },
   ],
 });
