typing for unproject_points

bottler · facebook-github-bot · commit 5053142363af · 2022-01-24T10:52:24.000-08:00
Summary: Fix the base class annotation for unproject_points.

Reviewed By: patricklabatut

Differential Revision: D33281586

fbshipit-source-id: 1c34e8c4b30b359fcb9307507bc778ad3fecf290
diff --git a/pytorch3d/renderer/cameras.py b/pytorch3d/renderer/cameras.py
@@ -98,7 +98,7 @@ def get_projection_transform(self):
         """
         raise NotImplementedError()
 
-    def unproject_points(self):
+    def unproject_points(self, xy_depth: torch.Tensor, **kwargs):
         """
         Transform input points from camera coodinates (NDC or screen)
         to the world / camera coordinates.
diff --git a/pytorch3d/renderer/implicit/raysampling.py b/pytorch3d/renderer/implicit/raysampling.py
@@ -549,7 +549,7 @@ def _xy_to_ray_bundle(
     )
 
     # unproject the points
-    unprojected = cameras.unproject_points(to_unproject, from_ndc=True)  # pyre-ignore
+    unprojected = cameras.unproject_points(to_unproject, from_ndc=True)
 
     # split the two planes back
     rays_plane_1_world = unprojected[:, :n_rays_per_image]

Original file line number	Diff line number	Diff line change
`@@ -549,7 +549,7 @@ def _xy_to_ray_bundle(`
`549`	`549`	`)`
`550`	`550`
`551`	`551`	`# unproject the points`
`552`		`- unprojected = cameras.unproject_points(to_unproject, from_ndc=True) # pyre-ignore`
	`552`	`+ unprojected = cameras.unproject_points(to_unproject, from_ndc=True)`
`553`	`553`
`554`	`554`	`# split the two planes back`
`555`	`555`	`rays_plane_1_world = unprojected[:, :n_rays_per_image]`