Backport legacy context deprecation warning

acdlite · acdlite · commit 415ee0e6ea0f · 2024-04-18T11:58:29.000-04:00
This backports a deprecation warning for legacy context, even when
Strict Mode is not enabled.

I didn't bother to update all the tests because the tests are in such
a different state than what's on `main`, and on `main` we already
updated the tests accordingly. So instead I silenced the warnings in
our test config, like we've done for other warnings in the past.
diff --git a/packages/react-reconciler/src/ReactFiberClassComponent.new.js b/packages/react-reconciler/src/ReactFiberClassComponent.new.js
@@ -96,6 +96,7 @@ let warnOnInvalidCallback;
 let didWarnAboutDirectlyAssigningPropsToState;
 let didWarnAboutContextTypeAndContextTypes;
 let didWarnAboutInvalidateContextType;
+let didWarnAboutLegacyContext;
 
 if (__DEV__) {
   didWarnAboutStateAssignmentForComponent = new Set();
@@ -106,6 +107,7 @@ if (__DEV__) {
   didWarnAboutUndefinedDerivedState = new Set();
   didWarnAboutContextTypeAndContextTypes = new Set();
   didWarnAboutInvalidateContextType = new Set();
+  didWarnAboutLegacyContext = new Set();
 
   const didWarnOnInvalidCallback = new Set();
 
@@ -435,6 +437,39 @@ function checkClassInstance(workInProgress: Fiber, ctor: any, newProps: any) {
         );
       }
     } else {
+      if (
+        ctor.childContextTypes &&
+        !didWarnAboutLegacyContext.has(ctor) &&
+        // Strict Mode has its own warning for legacy context, so we can skip
+        // this one.
+        (workInProgress.mode & StrictLegacyMode) === NoMode
+      ) {
+        didWarnAboutLegacyContext.add(ctor);
+        console.error(
+          '%s uses the legacy childContextTypes API which is no longer ' +
+            'supported and will be removed in the next major release. Use ' +
+            'React.createContext() instead\n\n.' +
+            'Learn more about this warning here: https://reactjs.org/link/legacy-context',
+          name,
+        );
+      }
+      if (
+        ctor.contextTypes &&
+        !didWarnAboutLegacyContext.has(ctor) &&
+        // Strict Mode has its own warning for legacy context, so we can skip
+        // this one.
+        (workInProgress.mode & StrictLegacyMode) === NoMode
+      ) {
+        didWarnAboutLegacyContext.add(ctor);
+        console.error(
+          '%s uses the legacy contextTypes API which is no longer supported ' +
+            'and will be removed in the next major release. Use ' +
+            'React.createContext() with static contextType instead.\n\n' +
+            'Learn more about this warning here: https://reactjs.org/link/legacy-context',
+          name,
+        );
+      }
+
       if (instance.contextTypes) {
         console.error(
           'contextTypes was defined as an instance property on %s. Use a static ' +
diff --git a/packages/react-reconciler/src/ReactFiberClassComponent.old.js b/packages/react-reconciler/src/ReactFiberClassComponent.old.js
@@ -96,6 +96,7 @@ let warnOnInvalidCallback;
 let didWarnAboutDirectlyAssigningPropsToState;
 let didWarnAboutContextTypeAndContextTypes;
 let didWarnAboutInvalidateContextType;
+let didWarnAboutLegacyContext;
 
 if (__DEV__) {
   didWarnAboutStateAssignmentForComponent = new Set();
@@ -106,6 +107,7 @@ if (__DEV__) {
   didWarnAboutUndefinedDerivedState = new Set();
   didWarnAboutContextTypeAndContextTypes = new Set();
   didWarnAboutInvalidateContextType = new Set();
+  didWarnAboutLegacyContext = new Set();
 
   const didWarnOnInvalidCallback = new Set();
 
@@ -435,6 +437,39 @@ function checkClassInstance(workInProgress: Fiber, ctor: any, newProps: any) {
         );
       }
     } else {
+      if (
+        ctor.childContextTypes &&
+        !didWarnAboutLegacyContext.has(ctor) &&
+        // Strict Mode has its own warning for legacy context, so we can skip
+        // this one.
+        (workInProgress.mode & StrictLegacyMode) === NoMode
+      ) {
+        didWarnAboutLegacyContext.add(ctor);
+        console.error(
+          '%s uses the legacy childContextTypes API which is no longer ' +
+            'supported and will be removed in the next major release. Use ' +
+            'React.createContext() instead\n\n.' +
+            'Learn more about this warning here: https://reactjs.org/link/legacy-context',
+          name,
+        );
+      }
+      if (
+        ctor.contextTypes &&
+        !didWarnAboutLegacyContext.has(ctor) &&
+        // Strict Mode has its own warning for legacy context, so we can skip
+        // this one.
+        (workInProgress.mode & StrictLegacyMode) === NoMode
+      ) {
+        didWarnAboutLegacyContext.add(ctor);
+        console.error(
+          '%s uses the legacy contextTypes API which is no longer supported ' +
+            'and will be removed in the next major release. Use ' +
+            'React.createContext() with static contextType instead.\n\n' +
+            'Learn more about this warning here: https://reactjs.org/link/legacy-context',
+          name,
+        );
+      }
+
       if (instance.contextTypes) {
         console.error(
           'contextTypes was defined as an instance property on %s. Use a static ' +
diff --git a/scripts/jest/shouldIgnoreConsoleError.js b/scripts/jest/shouldIgnoreConsoleError.js
@@ -23,6 +23,19 @@ module.exports = function shouldIgnoreConsoleError(format, args) {
         // We haven't finished migrating our tests to use createRoot.
         return true;
       }
+      if (
+        format.indexOf(
+          'uses the legacy contextTypes API which is no longer supported and will be removed'
+        ) !== -1 ||
+        format.indexOf(
+          'uses the legacy childContextTypes API which is no longer supported and will be removed'
+        ) !== -1
+      ) {
+        // This is a backported warning. In `main`, there's a different warning
+        // (and it's fully tested). Not going to bother upgrading all the tests
+        // on this old release branch, so let's just silence it instead.
+        return true;
+      }
     }
   } else {
     if (
