fix: false negatives for https in prefer-node-protocol, and false negatives for node:sqlite in node-builtins (#432)

ota-meshi · web-flow · commit bb21bd0f33a0 · 2025-05-09T00:56:01.000+01:00
diff --git a/lib/unsupported-features/node-builtins-modules/https.js b/lib/unsupported-features/node-builtins-modules/https.js
@@ -5,7 +5,7 @@ const { READ } = require("@eslint-community/eslint-utils")
 /**
  * @satisfies {import('../types.js').SupportVersionTraceMap}
  */
-const http = {
+const https = {
     globalAgent: { [READ]: { supported: ["0.5.9"] } },
     createServer: { [READ]: { supported: ["0.3.4"] } },
     get: { [READ]: { supported: ["0.3.6"] } },
@@ -18,12 +18,12 @@ const http = {
  * @satisfies {import('../types.js').SupportVersionTraceMap}
  */
 module.exports = {
-    http: {
+    https: {
         [READ]: { supported: ["0.3.4"] },
-        ...http,
+        ...https,
     },
-    "node:http": {
+    "node:https": {
         [READ]: { supported: ["14.13.1", "12.20.0"] },
-        ...http,
+        ...https,
     },
 }
diff --git a/lib/unsupported-features/node-builtins.js b/lib/unsupported-features/node-builtins.js
@@ -37,6 +37,7 @@ const NodeBuiltinModules = {
     ...require("./node-builtins-modules/sea.js"),
     ...require("./node-builtins-modules/stream.js"),
     ...require("./node-builtins-modules/string_decoder.js"),
+    ...require("./node-builtins-modules/sqlite.js"),
     ...require("./node-builtins-modules/test.js"),
     ...require("./node-builtins-modules/timers.js"),
     ...require("./node-builtins-modules/tls.js"),
diff --git a/tests/lib/rules/no-unsupported-features/node-builtins.js b/tests/lib/rules/no-unsupported-features/node-builtins.js
@@ -5626,5 +5626,130 @@ new RuleTester({ languageOptions: { sourceType: "module" } }).run(
                 },
             ],
         },
+
+        //----------------------------------------------------------------------
+        // sqlite
+        //----------------------------------------------------------------------
+        {
+            valid: [
+                {
+                    code: `
+                        import { DatabaseSync } from 'node:sqlite';
+                        const database = new DatabaseSync(':memory:');
+                    `,
+                    options: [
+                        {
+                            version: ">=22.5.0",
+                            allowExperimental: true,
+                        },
+                    ],
+                    languageOptions: { ecmaVersion: "latest" },
+                },
+                {
+                    code: `
+                        import { DatabaseSync } from 'node:sqlite';
+                        const database = new DatabaseSync(':memory:');
+                    `,
+                    options: [
+                        {
+                            version: ">=22.3.0",
+                            ignores: ["sqlite", "sqlite.DatabaseSync"],
+                        },
+                    ],
+                    languageOptions: { ecmaVersion: "latest" },
+                },
+                {
+                    code: `
+                        const { DatabaseSync } = require('node:sqlite');
+                        const database = new DatabaseSync(':memory:');
+                    `,
+                    options: [
+                        {
+                            version: ">=22.5.0",
+                            allowExperimental: true,
+                        },
+                    ],
+                    languageOptions: { ecmaVersion: "latest" },
+                },
+            ],
+            invalid: [
+                {
+                    code: `
+                        import { DatabaseSync } from 'node:sqlite';
+                        const database = new DatabaseSync(':memory:');
+                    `,
+                    options: [
+                        {
+                            version: ">=22.5.0",
+                        },
+                    ],
+                    languageOptions: { ecmaVersion: "latest" },
+
+                    errors: [
+                        {
+                            messageId: "not-supported-yet",
+                            data: {
+                                name: "sqlite",
+                                version: ">=22.5.0",
+                            },
+                        },
+                    ],
+                },
+                {
+                    code: `
+                        import { DatabaseSync } from 'node:sqlite';
+                        const database = new DatabaseSync(':memory:');
+                    `,
+                    options: [{ version: ">=22.3.0", allowExperimental: true }],
+                    languageOptions: { ecmaVersion: "latest" },
+
+                    errors: [
+                        {
+                            messageId: "not-experimental-till",
+                            data: {
+                                name: "sqlite",
+                                experimental: "22.5.0",
+                                version: ">=22.3.0",
+                            },
+                        },
+                        {
+                            messageId: "not-supported-till",
+                            data: {
+                                name: "sqlite.DatabaseSync",
+                                supported: "22.5.0",
+                                version: ">=22.3.0",
+                            },
+                        },
+                    ],
+                },
+                {
+                    code: `
+                        const { DatabaseSync } = require('node:sqlite');
+                        const database = new DatabaseSync(':memory:');
+                    `,
+                    options: [{ version: ">=22.3.0", allowExperimental: true }],
+                    languageOptions: { ecmaVersion: "latest" },
+
+                    errors: [
+                        {
+                            messageId: "not-supported-till",
+                            data: {
+                                name: "sqlite.DatabaseSync",
+                                supported: "22.5.0",
+                                version: ">=22.3.0",
+                            },
+                        },
+                        {
+                            messageId: "not-experimental-till",
+                            data: {
+                                name: "sqlite",
+                                experimental: "22.5.0",
+                                version: ">=22.3.0",
+                            },
+                        },
+                    ],
+                },
+            ],
+        },
     ])
 )
diff --git a/tests/lib/rules/prefer-node-protocol.js b/tests/lib/rules/prefer-node-protocol.js
@@ -242,5 +242,12 @@ new RuleTester({
             `,
             errors: ["Prefer `node:buffer` over `buffer`."],
         },
+
+        // https://github.com/eslint-community/eslint-plugin-n/issues/431
+        {
+            code: 'import https from "https";',
+            output: 'import https from "node:https";',
+            errors: ["Prefer `node:https` over `https`."],
+        },
     ],
 })
diff --git a/tests/lib/unsupported-features/node-builtins.js b/tests/lib/unsupported-features/node-builtins.js
@@ -0,0 +1,31 @@
+"use strict"
+const fs = require("fs")
+const path = require("path")
+
+const {
+    NodeBuiltinModules,
+} = require("../../../lib/unsupported-features/node-builtins")
+const assert = require("assert")
+
+const RESOURCES_ROOT = path.resolve(
+    __dirname,
+    "../../../lib/unsupported-features/node-builtins-modules"
+)
+
+describe("unsupported-features/node-builtins", () => {
+    for (const dirent of fs.readdirSync(RESOURCES_ROOT, {
+        withFileTypes: true,
+    })) {
+        if (!dirent.isFile() || !dirent.name.endsWith(".js")) continue
+        const filePath = path.join(RESOURCES_ROOT, dirent.name)
+        const resource = require(filePath)
+        it(`should be the same resource defined in ${dirent.name} that is defined in NodeBuiltinModules.`, () => {
+            const picked = Object.fromEntries(
+                Object.entries(NodeBuiltinModules).filter(
+                    ([key]) => resource[key]
+                )
+            )
+            assert.deepStrictEqual(picked, resource)
+        })
+    }
+})
