fix: better completions for function references (#500)

mhanberg · web-flow · commit c4a6852548d2 · 2024-05-23T09:11:23.000-04:00
Removes `&amp;` as a trigger character, which will allow completions to
trigger as normal once you start typing after.

This shouldn't be a problem as the only two completions offered by that
are `&amp;` and `&amp;&amp;`, and operators like `||` don't complete anyway.
diff --git a/lib/next_ls.ex b/lib/next_ls.ex
@@ -159,7 +159,7 @@ defmodule NextLS do
          completion_provider:
            if init_opts.experimental.completions.enable do
              %GenLSP.Structures.CompletionOptions{
-               trigger_characters: [".", "@", "&", "%", "^", ":", "!", "-", "~", "/", "{"],
+               trigger_characters: [".", "@", "%", "^", ":", "!", "-", "~", "/", "{"],
                resolve_provider: true
              }
            end,
diff --git a/lib/next_ls/autocomplete.ex b/lib/next_ls/autocomplete.ex
@@ -72,7 +72,7 @@ defmodule NextLS.Autocomplete do
         hint = List.to_string(local_or_var)
 
         expand_container_context(code, :expr, hint, runtime, env) ||
-          expand_local_or_var(hint, List.to_string(local_or_var), runtime, env)
+          expand_local_or_var(hint, hint, runtime, env)
 
       {:local_arity, local} ->
         expand_local(List.to_string(local), true, runtime, env)

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ defmodule NextLS do`
`159`	`159`	`completion_provider:`
`160`	`160`	`if init_opts.experimental.completions.enable do`
`161`	`161`	`%GenLSP.Structures.CompletionOptions{`
`162`		`- trigger_characters: [".", "@", "&", "%", "^", ":", "!", "-", "~", "/", "{"],`
	`162`	`+ trigger_characters: [".", "@", "%", "^", ":", "!", "-", "~", "/", "{"],`
`163`	`163`	`resolve_provider: true`
`164`	`164`	`}`
`165`	`165`	`end,`