CARVIEW |
Select Language
HTTP/2 200
date: Mon, 28 Jul 2025 07:25:51 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-repository-download: git clone https://github.com/dotnet/android.git
etag: W/"d96b5e5207e036335608def5c071500e"
cache-control: max-age=0, private, must-revalidate
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=qu4roY3UvWc1R3l82mgOP1iooT1%2FkZkhoR%2FalY99qGGALlYDfU8lWKePj7sj%2FNp%2BIuAx7qcF%2BvzRLyNiYYx6QNPnW1ZNhvZdhb4KQ9zuQeiynbpFNANlGQ%2BavHNmcDBEEuI2hgY01lbLwjAmdjSxRAHU2Cb6s9wC8wXGmLX3DZiouochp%2BPrhe333CjL40rbDCsBy6hPsaKC48EMc5H5S0UjcxJe9BYc0DTjPMiFeQG6Rwxo0mxdo%2FP6nKsxwia%2FtvK6lYx82%2Ftz8RYXmWkQ7g%3D%3D--PaKknNxBddBZjBtU--2JbZaRV%2FvDcNw2qHl9cOpQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1050466037.1753687550; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 07:25:50 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 07:25:50 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9A40:2CB2E7:1659924:1D17D03:688725FE
[Xamarin.Android.Build.Tasks] not so many log messages! (#2952) · dotnet/android@28e1f93 · GitHub
Dismiss banner
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/Aapt.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/Aapt2Compile.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/Aapt2Link.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/AdjustJavacVersionArguments.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/AndroidApkSigner.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/AndroidCreateDebugKey.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/AndroidUpdateResDir.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/AndroidZipAlign.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/CalculateAdditionalResourceCacheDirectories.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/CalculateLayoutCodeBehind.cs
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 555
Commit 28e1f93
[Xamarin.Android.Build.Tasks] not so many log messages! (#2952)
We used to have the pattern of including log messages at the beginning
of `Execute()` in MSBuild tasks:
Log.LogDebugMessage ("MyMSBuildTask Task");
Log.LogDebugMessage (" FooProperty: {0}", FooProperty);
Log.LogDebugTaskItems (" BarItems: ", BarItems);
This was mostly here to improve diagnostic log output from XBuild,
which we no longer support.
MSBuild properly logs any input properties on MSBuild tasks, so we
can remove a lot of code!
There were a couple places I could go a step further:
* `<AndroidCreateDebugKey/>` and `<AndroidZipAlign/>` I could
remove the entire `Execute()` method.
* `<JavaCompileToolTask/>` had an `OnLogStarted` method I could
remove. `<Javac/>` also was overriding this method.
I thought this might have *some* impact on build times, since logging
and `string.Format()` takes some time (it's not free!).
A build of the Xamarin.Forms app in this repo:
# Before
Time Elapsed 00:00:25.66
Time Elapsed 00:00:25.36
Time Elapsed 00:00:25.67
# After
Time Elapsed 00:00:24.58
Time Elapsed 00:00:23.98
Time Elapsed 00:00:24.98
The overall build times vary quite a bit. So if I took a
conservative estimate it seems the initial build is 500ms better?
A more revealing difference, I think, is the size of these binlog
files:
# fresh build
746947 before.first.binlog
740797 after.first.binlog
# build with no changes
827913 before.second.binlog
825665 after.second.binlog
# build with xaml change
848821 before.third.binlog
844365 after.third.binlog
These files are compressed, so if they are 2K-6K smaller that was a
lot of log messages...1 parent 51c8fc6 commit 28e1f93Copy full SHA for 28e1f93
File tree
Expand file treeCollapse file tree
47 files changed
+0
-287
lines changedFilter options
- src/Xamarin.Android.Build.Tasks/Tasks
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Expand file treeCollapse file tree
47 files changed
+0
-287
lines changedsrc/Xamarin.Android.Build.Tasks/Tasks/Aapt.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/Aapt.cs-19Lines changed: 0 additions & 19 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
211 | 211 |
| |
212 | 212 |
| |
213 | 213 |
| |
214 |
| - | |
215 |
| - | |
216 |
| - | |
217 |
| - | |
218 |
| - | |
219 |
| - | |
220 |
| - | |
221 |
| - | |
222 |
| - | |
223 |
| - | |
224 |
| - | |
225 |
| - | |
226 |
| - | |
227 |
| - | |
228 |
| - | |
229 |
| - | |
230 |
| - | |
231 |
| - | |
232 |
| - | |
233 | 214 |
| |
234 | 215 |
| |
235 | 216 |
| |
|
src/Xamarin.Android.Build.Tasks/Tasks/Aapt2Compile.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/Aapt2Compile.cs-5Lines changed: 0 additions & 5 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
30 | 30 |
| |
31 | 31 |
| |
32 | 32 |
| |
33 |
| - | |
34 |
| - | |
35 |
| - | |
36 |
| - | |
37 |
| - | |
38 | 33 |
| |
39 | 34 |
| |
40 | 35 |
| |
|
src/Xamarin.Android.Build.Tasks/Tasks/Aapt2Link.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/Aapt2Link.cs-3Lines changed: 0 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
77 | 77 |
| |
78 | 78 |
| |
79 | 79 |
| |
80 |
| - | |
81 |
| - | |
82 |
| - | |
83 | 80 |
| |
84 | 81 |
| |
85 | 82 |
| |
|
src/Xamarin.Android.Build.Tasks/Tasks/AdjustJavacVersionArguments.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/AdjustJavacVersionArguments.cs-6Lines changed: 0 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
29 | 29 |
| |
30 | 30 |
| |
31 | 31 |
| |
32 |
| - | |
33 |
| - | |
34 |
| - | |
35 |
| - | |
36 |
| - | |
37 |
| - | |
38 | 32 |
| |
39 | 33 |
| |
40 | 34 |
| |
|
src/Xamarin.Android.Build.Tasks/Tasks/AndroidApkSigner.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/AndroidApkSigner.cs-6Lines changed: 0 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
33 | 33 |
| |
34 | 34 |
| |
35 | 35 |
| |
36 |
| - | |
37 |
| - | |
38 |
| - | |
39 |
| - | |
40 |
| - | |
41 |
| - | |
42 | 36 |
| |
43 | 37 |
| |
44 | 38 |
| |
|
src/Xamarin.Android.Build.Tasks/Tasks/AndroidCreateDebugKey.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/AndroidCreateDebugKey.cs-8Lines changed: 0 additions & 8 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
19 | 19 |
| |
20 | 20 |
| |
21 | 21 |
| |
22 |
| - | |
23 |
| - | |
24 |
| - | |
25 |
| - | |
26 |
| - | |
27 |
| - | |
28 |
| - | |
29 |
| - | |
30 | 22 |
| |
31 | 23 |
| |
32 | 24 |
| |
|
src/Xamarin.Android.Build.Tasks/Tasks/AndroidUpdateResDir.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/AndroidUpdateResDir.cs-11Lines changed: 0 additions & 11 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
59 | 59 |
| |
60 | 60 |
| |
61 | 61 |
| |
62 |
| - | |
63 |
| - | |
64 |
| - | |
65 |
| - | |
66 |
| - | |
67 |
| - | |
68 | 62 |
| |
69 | 63 |
| |
70 | 64 |
| |
| |||
155 | 149 |
| |
156 | 150 |
| |
157 | 151 |
| |
158 |
| - | |
159 |
| - | |
160 |
| - | |
161 |
| - | |
162 |
| - | |
163 | 152 |
| |
164 | 153 |
| |
165 | 154 |
| |
|
src/Xamarin.Android.Build.Tasks/Tasks/AndroidZipAlign.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/AndroidZipAlign.cs-10Lines changed: 0 additions & 10 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
40 | 40 |
| |
41 | 41 |
| |
42 | 42 |
| |
43 |
| - | |
44 |
| - | |
45 |
| - | |
46 |
| - | |
47 |
| - | |
48 |
| - | |
49 |
| - | |
50 |
| - | |
51 |
| - | |
52 |
| - | |
53 | 43 |
| |
54 | 44 |
| |
55 | 45 |
| |
|
src/Xamarin.Android.Build.Tasks/Tasks/CalculateAdditionalResourceCacheDirectories.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/CalculateAdditionalResourceCacheDirectories.cs-4Lines changed: 0 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
23 | 23 |
| |
24 | 24 |
| |
25 | 25 |
| |
26 |
| - | |
27 |
| - | |
28 |
| - | |
29 |
| - | |
30 | 26 |
| |
31 | 27 |
| |
32 | 28 |
| |
|
src/Xamarin.Android.Build.Tasks/Tasks/CalculateLayoutCodeBehind.cs
Copy file name to clipboardExpand all lines: src/Xamarin.Android.Build.Tasks/Tasks/CalculateLayoutCodeBehind.cs-7Lines changed: 0 additions & 7 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
113 | 113 |
| |
114 | 114 |
| |
115 | 115 |
| |
116 |
| - | |
117 |
| - | |
118 |
| - | |
119 |
| - | |
120 |
| - | |
121 |
| - | |
122 |
| - | |
123 | 116 |
| |
124 | 117 |
| |
125 | 118 |
| |
|
You can’t perform that action at this time.
0 commit comments