Dynamic datasource framework init #73

louyuting · 2020-02-28T16:10:40Z

Describe what this PR does / why we need it

Does this pull request fix one issue?

Will define the dynamic data source extension framework.

Describe how you did it

Describe how to verify it

Special notes for reviews

gorexlv · 2020-03-02T04:06:53Z

extension/refreshable_file/ext_system.go

+	if src == nil {
+		return nil
+	}
+	rs := gjson.ParseBytes(src).Array()


This is a little problem: what should I do if the data souce is a file in toml format?

gorexlv · 2020-03-02T04:08:10Z

extension/refreshable_file/ext_system.go

+	"github.com/tidwall/gjson"
+)
+
+func SystemRulesConvert(src []byte) interface{} {


[]byte looks a little strange, how about io.Reader?

wenxuwan · 2020-03-03T02:33:26Z

extension/refreshable_file/ext_system.go

+		return errors.New(fmt.Sprintf("Invalid parameters: data:%+v", data))
+	}
+	val, ok := data.([]*system.SystemRule)
+	if !ok {


Do we need compare the data in cache with the new data like the Java design? Or update the value in cache directly?

wenxuwan · 2020-03-04T07:45:18Z

extension/refreshable_file/file_datasource.go

+	return ds
+}
+
+func (ds *FileDataSource) listen() {


As you add two function for type DataSource interface, all the specific datasource should implement it.

wenxuwan · 2020-03-04T07:47:08Z

extension/refreshable_file/file_datasource_test.go

+//}
+
+func TestNewFileDataSource_SystemRule(t *testing.T) {
+	ds := FileDataSourceStarter("../../tests/testdata/extension/refreshable_file/SystemRule.json", ext.NewSystemRulesHandle())


For a better understanding of the frame, I think should declare ds with DataSource type.

sczyh30 · 2020-03-09T12:57:03Z

extension/property.go

+	realSrc, err := json.Marshal(realProperty)
+	if err!=nil {
+		logger.Warnf("Fail to marshal property source, err:%+v.", err)
+	}
+	isConsistent := h.isPropertyConsistent(realSrc)


Maybe we can compare the parsed entity directly, rather than convert it to JSON string then compare.

sczyh30 · 2020-03-09T13:25:16Z

extension/property.go

+type DefaultPropertyHandler struct {
+	lastUpdateProperty interface{}
+
+	Convert PropertyConvert


Make it private and access it with the getter method?

ext/datasource/property.go

sczyh30

LGTM

sczyh30 · 2020-03-09T14:07:48Z

Nice work. Thanks!

louyuting force-pushed the file-data-source branch from f031332 to 8554653 Compare March 1, 2020 16:13

gorexlv reviewed Mar 2, 2020

View reviewed changes

wenxuwan reviewed Mar 3, 2020

View reviewed changes

wenxuwan reviewed Mar 4, 2020

View reviewed changes

louyuting force-pushed the file-data-source branch from 7e03d5f to 2fff20e Compare March 7, 2020 07:51

louyuting marked this pull request as ready for review March 7, 2020 08:22

louyuting requested a review from sczyh30 March 7, 2020 08:23

louyuting added kind/feature Category issues or PRs related to feature request to-review PRs to review labels Mar 7, 2020

sczyh30 reviewed Mar 9, 2020

View reviewed changes

datasource extension framework initialization.

d7d6a6c

louyuting force-pushed the file-data-source branch from f6c1bcd to d7d6a6c Compare March 9, 2020 13:40

louyuting requested a review from sczyh30 March 9, 2020 13:43

sczyh30 reviewed Mar 9, 2020

View reviewed changes

ext/datasource/property.go Outdated Show resolved Hide resolved

refine code

b8ac668

sczyh30 added the area/data-source Issues or PRs related to data-source extension label Mar 9, 2020

sczyh30 approved these changes Mar 9, 2020

View reviewed changes

sczyh30 merged commit 1c1d2e1 into alibaba:master Mar 9, 2020

sczyh30 removed the to-review PRs to review label Mar 9, 2020

This was referenced Mar 9, 2020

Basic abstraction for data-source extension #58

Closed

Add etcd data-source extenstion #51

Closed

sczyh30 linked an issue Mar 10, 2020 that may be closed by this pull request

Basic abstraction for data-source extension #58

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dynamic datasource framework init #73

Dynamic datasource framework init #73

Uh oh!

louyuting commented Feb 28, 2020 •

edited

Loading

Uh oh!

gorexlv Mar 2, 2020

Uh oh!

gorexlv Mar 2, 2020

Uh oh!

wenxuwan Mar 3, 2020

Uh oh!

wenxuwan Mar 4, 2020

Uh oh!

wenxuwan Mar 4, 2020 •

edited

Loading

Uh oh!

sczyh30 Mar 9, 2020

Uh oh!

sczyh30 Mar 9, 2020

Uh oh!

Uh oh!

sczyh30 left a comment

Uh oh!

sczyh30 commented Mar 9, 2020

Uh oh!

Uh oh!

Dynamic datasource framework init #73

Dynamic datasource framework init #73

Uh oh!

Conversation

louyuting commented Feb 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

Uh oh!

gorexlv Mar 2, 2020

Choose a reason for hiding this comment

Uh oh!

gorexlv Mar 2, 2020

Choose a reason for hiding this comment

Uh oh!

wenxuwan Mar 3, 2020

Choose a reason for hiding this comment

Uh oh!

wenxuwan Mar 4, 2020

Choose a reason for hiding this comment

Uh oh!

wenxuwan Mar 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sczyh30 Mar 9, 2020

Choose a reason for hiding this comment

Uh oh!

sczyh30 Mar 9, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sczyh30 left a comment

Choose a reason for hiding this comment

Uh oh!

sczyh30 commented Mar 9, 2020

Uh oh!

Uh oh!

louyuting commented Feb 28, 2020 •

edited

Loading

wenxuwan Mar 4, 2020 •

edited

Loading