| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 17:20:43 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=301.675499,conversation_content-fragment;desc="conversation_content fragment";dur=547.655712,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=220.9545,nginx;desc="NGINX";dur=1.347161,glb;desc="GLB";dur=101.049197
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=4W8ifEGZtyPwDeJyfZDv2Ey3wKLTWA3F7a%2B%2BbhIIDP%2F6CN%2Bl0j6TguLgBNwBt0AvlnHsHWmz91S2XVT8G9KMSi1tVU%2BGkPUSTLnwuJFxYpUPuYWUI8AuyqiHDxtqwlq%2Fris65Fu980veyClxziEGVGr%2BHsbGR7j1iANN%2BhjPywms1969dSF35qjJuoo%2F1k34%2F1q4x0UQO2TOIBHLPS7lEjKFuo%2Fk%2BojXm%2Ba0Q1yAc49pB6fbmRUzJOeKUXKGh78kDzG5fXFkIOIzmwmj5HTgGw%3D%3D--JohFFCBUNbH880ar--ZWihIbc03YopZswHobYzSA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.554806740.1753636842; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 17:20:42 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 17:20:42 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BAF4:1AFF47:104E329:155F9D4:68865FEA
Fix bugs of throttling control behavior in flow control module by sczyh30 · Pull Request #332 · alibaba/sentinel-golang · GitHub
sczyh30
added
kind/bug
Something isn't working
kind/enhancement
Category issues or PRs related to enhancement
area/flow-control
Issues or PRs related to flow control
labels
Nov 25, 2020
sczyh30
force-pushed
the
fix-throttling-overflow
branch
from
November 26, 2020 02:28
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 445
Fix bugs of throttling control behavior in flow control module #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sczyh30
added
kind/bug
|
Also cc @NineSunRD @luckyxiaoqiang @sanxun0325 |
louyuting
reviewed
Nov 25, 2020
…lated stat slots Signed-off-by: Eric Zhao <sczyh16@gmail.com>
…cker may overflow * Use int64 instead of uint64 here * Update wait duration to nanos Signed-off-by: Eric Zhao <sczyh16@gmail.com>
sczyh30
force-pushed
the
fix-throttling-overflow
branch
from
6a0224b to
d443d80
Compare
louyuting
approved these changes
Nov 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/flow-control
Issues or PRs related to flow control
kind/bug
Something isn't working
kind/enhancement
Category issues or PRs related to enhancement
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Describe what this PR does / why we need it
Fix bugs of throttling control behavior in flow control module, including overflow bug and time unit bug of wait duration.
Does this pull request fix one issue?
Fixes #331
Describe how you did it
waitMstonanosToWaitinTokenResultand polish related stat slots. Here we SHOULD use nanos instead of millis, or the queueing interval may not be accurate.estimatedQueueingDurationin throttling checker may overflow. Use int64 instead.Describe how to verify it
Run the test cases and demo.
Special notes for reviews
NONE.