| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 12:50:50 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=263.521958,conversation_content-fragment;desc="conversation_content fragment";dur=565.531501,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=251.815816,nginx;desc="NGINX";dur=1.126759,glb;desc="GLB";dur=141.57864
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=fuSH1CC9W7CZ8xhb8UNVJqgKANks0l9illTKcT9ozBLFa9ueiopGGJzJh1CrzFz2Q7f1A4RRW3pXHyATIYF5vzpg9TDLG%2B1RLD%2BEF4XrxKPIsIDxpnUUKfDsdt4nxbqBjpnACpFVSciTGxYX1DJfwBkBbNmDvh3nfafkwKLXP5hpgcuKb8yjomb9ITy%2F%2F3jxKnsdbQ89bjE2AMJR5BAuJ%2F0lZOlrEqi0I4rb3Yz0WxM4UnQ5G8oQW%2BMS4iexlzZ7CjahRQ%2FcwTsXz6jcfk%2B8jw%3D%3D--XsrvSJJWYMfRhk7G--tgDE%2BrkTL3%2B8i0i3Xks5EQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1622782375.1753620650; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 12:50:50 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 12:50:50 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BFC4:3C6DB4:4E5800:6848CE:688620AA
Add cache mechanism for LoadRules in circuitbreaker module by binbin0325 · Pull Request #324 · alibaba/sentinel-golang · GitHub
louyuting
added
the
area/circuit-breaking
Issues or PRs related to circuit breaking
label
Nov 14, 2020
binbin0325
force-pushed
the
circuitbreaker_rule_cache
branch
from
November 15, 2020 12:11
louyuting
force-pushed
the
circuitbreaker_rule_cache
branch
from
November 16, 2020 13:12
louyuting
changed the title
Loading circuitbreaker rule supports cache
Add cache mechanism for LoadRules in circuitbreaker module
Nov 16, 2020
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 445
Add cache mechanism for LoadRules in circuitbreaker module #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
louyuting
merged 2 commits into
alibaba:master
from
binbin0325:circuitbreaker_rule_cache
Nov 16, 2020
Merged
Add cache mechanism for LoadRules in circuitbreaker module #324
louyuting
merged 2 commits into
alibaba:master
from
binbin0325:circuitbreaker_rule_cache
Nov 16, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 50.41% 50.66% +0.24%
==========================================
Files 68 68
Lines 3709 3774 +65
==========================================
+ Hits 1870 1912 +42
- Misses 1577 1597 +20
- Partials 262 265 +3
Continue to review full report at Codecov.
|
louyuting
added
the
area/circuit-breaking
louyuting
reviewed
Nov 14, 2020
binbin0325
force-pushed
the
circuitbreaker_rule_cache
branch
from
3b9d70f to
162dc70
Compare
sczyh30
previously approved these changes
Nov 16, 2020
louyuting
force-pushed
the
circuitbreaker_rule_cache
branch
from
162dc70 to
e1da2ec
Compare
louyuting
approved these changes
Nov 16, 2020
louyuting
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Describe what this PR does / why we need it
In order to avoid the meaningless updates to the property, downstream of property manager should
cache last update value to check consistency.
Does this pull request fix one issue?
Fix:#111
Describe how you did it
Using reflect.deepequal,maybe we need to think about performance
Describe how to verify it
ut
Special notes for reviews