update datasource_flow_json_parsers #198

binbin0325 · 2020-08-02T02:57:10Z

Describe what this PR does / why we need it

update datasource_flow_json_parsers

Does this pull request fix one issue?

fix：#191

Describe how to verify it

go test -v -race ./...

Special notes for reviews

codecov-commenter · 2020-08-02T02:59:44Z

Codecov Report

Merging #198 into master will decrease coverage by 0.54%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
- Coverage   44.80%   44.25%   -0.55%     
==========================================
  Files          80       80              
  Lines        4464     4424      -40     
==========================================
- Hits         2000     1958      -42     
- Misses       2235     2236       +1     
- Partials      229      230       +1

Impacted Files	Coverage Δ
core/flow/rule.go	`0.00% <ø> (ø)`
core/system/rule.go	`90.00% <ø> (ø)`
core/hotspot/rule.go	`66.25% <75.00%> (ø)`
ext/datasource/helper.go	`66.90% <81.81%> (-8.52%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a5dba...7a5c337. Read the comment docs.

louyuting · 2020-08-04T12:46:33Z

Could you please update json array parser for other rules?

binbin0325 · 2020-08-06T10:06:45Z

@louyuting There are still some parts that have not been modified. You can first see whether the modified is ok

binbin0325 · 2020-08-07T08:07:14Z

@louyuting Please help with the review.

core/hotspot/rule_manager.go

core/flow/rule.go

core/hotspot/rule.go

core/system/rule.go

ext/datasource/helper.go

louyuting · 2020-08-08T14:07:46Z

ext/datasource/helper.go

-// SystemRulesJsonConverter provide JSON  as the default serialization for list of system.SystemRule
-func SystemRulesJsonConverter(src []byte) (interface{}, error) {
+// SystemRulesJsonArrayParser provide JSON  as the default serialization for list of system.SystemRule
+func SystemRulesJsonArrayParser(src []byte) (interface{}, error) {


keep naming convention consistent.
Maybe "SystemRuleJsonArrayParser" be better?

louyuting · 2020-08-08T14:08:32Z

ext/datasource/helper.go

-// HotSpotParamRulesJsonConverter decodes list of param flow rules from JSON bytes.
-func HotSpotParamRulesJsonConverter(src []byte) (interface{}, error) {
+// HotSpotParamRulesJsonArrayParser decodes list of param flow rules from JSON bytes.
+func HotSpotParamRulesJsonArrayParser(src []byte) (interface{}, error) {


Same thing as up

louyuting · 2020-08-09T08:19:38Z

@sczyh30 could you please take a look at this PR?

sczyh30

LGTM

sczyh30 · 2020-08-11T02:03:10Z

Nice work. Thanks for contributing!

update datasource_flow_json_parsers

25002cf

sczyh30 added area/data-source Issues or PRs related to data-source extension to-review PRs to review labels Aug 3, 2020

sczyh30 requested review from louyuting and sczyh30 August 3, 2020 03:48

update system rule

7126a92

binbin0325 added 2 commits August 6, 2020 18:00

update hotspot

c09904b

Merge branch 'master' into datasource_json_parsers

993caee

binbin0325 changed the title ~~update datasource_flow_json_parsers~~ [WIP]update datasource_flow_json_parsers Aug 6, 2020

update hotspot json

041acb6

binbin0325 changed the title ~~[WIP]update datasource_flow_json_parsers~~ update datasource_flow_json_parsers Aug 7, 2020