CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 11:26:07 GMT
content-type: text/html; charset=utf-8
cache-control: max-age=0, private, must-revalidate
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
link: ; rel=preload; as=fetch; crossorigin=use-credentials
referrer-policy: no-referrer-when-downgrade
server-timing: issue_layout-fragment;desc="issue_layout fragment";dur=306.125684,issue_conversation_content-fragment;desc="issue_conversation_content fragment";dur=445.223213,issue_conversation_sidebar-fragment;desc="issue_conversation_sidebar fragment";dur=49.469247,nginx;desc="NGINX";dur=1.092974,glb;desc="GLB";dur=94.940974
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With, Accept,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=He06MTdecxY1BogBVrJJSkpgjPf9s41kk13tw%2BQUtQ%2F1MYlhvR8vc9RLolSSGjVy%2BV14vCwZiXkWfX3hyrKeOcnYwLfMFZSPhVU5e3k4XLKWDdkfUipS9tQ%2Fxp85BWARG7zPW7GJMfCQDOTOnCpYnQ53eN%2FAFPhEbDK1d11h%2FyRF7Z1HCZWIx7RTsrSxDWWVPcipq%2Ba2Fw92I%2BwbJ1sqt2gNb%2FWmja0Mw2fiamCaZBgdUfHykcnF%2FqUdGakGnDuoPWRk2XNyj8qtbNpiIH6zjA%3D%3D--n4sdAMwvwHLyfmqj--HWDoMsmWkXVQfhizNxXlSg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1784364971.1752924366; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:26:06 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:26:06 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D14A:35CC93:23D8BD:2C1C4C:687B80CE
OftDecoder doesn't provide the name of the type on the typeToken when encoding is nested in a composite · Issue #477 · aeron-io/simple-binary-encoding · GitHub
No one assignedNo labelsNo typeNo projectsNo milestoneNone yetNo branches or pull requests
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 542
Closed
Description
If I have a type nested within a composite, when I arrive at the onEncoding callback the typeToken doesn't reference the type as described in the type parameter of the ref element: <ref name="otherInstructionId" type="Fix24CharString"/>
.
Using the supplied code I get the following output. When we arrive at the instructionId field on the message the typeToken contains the name of the correct type (Fix24CharString), where as we we arrive at orderState.otherInstructionId, the typeToken contains the name of the ref (otherInstructionId), where as I would expect either the name or referencedName to contain the name of the type:
instructionId
fieldToken: Token{signal=BEGIN_FIELD, name='instructionId', referencedName='null', description='null', id=4, version=0, deprecated=0, encodedLength=0, offset=0, componentTokenCount=3, encoding=Encoding{presence=REQUIRED, primitiveType=null, byteOrder=LITTLE_ENDIAN, minValue=null, maxValue=null, nullValue=null, constValue=null, characterEncoding='null', epoch='unix', timeUnit=nanosecond, semanticType='null'}}
typeToken : Token{signal=ENCODING, name='Fix24CharString', referencedName='null', description='null', id=-1, version=0, deprecated=0, encodedLength=24, offset=0, componentTokenCount=1, encoding=Encoding{presence=REQUIRED, primitiveType=CHAR, byteOrder=LITTLE_ENDIAN, minValue=null, maxValue=null, nullValue=null, constValue=null, characterEncoding='US-ASCII', epoch='unix', timeUnit=nanosecond, semanticType='null'}}
orderState.otherInstructionId
fieldToken: Token{signal=ENCODING, name='otherInstructionId', referencedName='null', description='null', id=-1, version=0, deprecated=0, encodedLength=24, offset=0, componentTokenCount=1, encoding=Encoding{presence=REQUIRED, primitiveType=CHAR, byteOrder=LITTLE_ENDIAN, minValue=null, maxValue=null, nullValue=null, constValue=null, characterEncoding='US-ASCII', epoch='null', timeUnit=null, semanticType='null'}}
typeToken : Token{signal=ENCODING, name='otherInstructionId', referencedName='null', description='null', id=-1, version=0, deprecated=0, encodedLength=24, offset=0, componentTokenCount=1, encoding=Encoding{presence=REQUIRED, primitiveType=CHAR, byteOrder=LITTLE_ENDIAN, minValue=null, maxValue=null, nullValue=null, constValue=null, characterEncoding='US-ASCII', epoch='null', timeUnit=null, semanticType='null'}}
Schema:
<?xml version="1.0" encoding="UTF-8"?>
<sbe:messageSchema
xmlns:sbe="https://fixprotocol.io/2016/sbe"
package="sbeir.bug"
id="10001"
version="209"
description="Order Book Events persistent structure"
byteOrder="littleEndian">
<types>
<composite name="messageHeader" description="Message identifiers and length of message root">
<type name="blockLength" primitiveType="uint16"/>
<type name="templateId" primitiveType="uint16"/>
<type name="schemaId" primitiveType="uint16"/>
<type name="version" primitiveType="uint16"/>
</composite>
<type name="Fix24CharString" primitiveType="char" length="24"/>
<composite name="EvOrderState">
<ref name="otherInstructionId" type="Fix24CharString"/>
</composite>
</types>
<sbe:message name="ExecutionReport" id="3">
<field name="instructionId" id="4" type="Fix24CharString"/>
<field name="orderState" id="5" type="EvOrderState"/>
</sbe:message>
</sbe:messageSchema>
Code:
import org.agrona.DirectBuffer;
import org.agrona.concurrent.UnsafeBuffer;
import org.junit.Test;
import sbeir.bug.ExecutionReportEncoder;
import sbeir.bug.MessageHeaderEncoder;
import uk.co.real_logic.sbe.ir.Ir;
import uk.co.real_logic.sbe.ir.IrDecoder;
import uk.co.real_logic.sbe.ir.Token;
import uk.co.real_logic.sbe.otf.AbstractTokenListener;
import uk.co.real_logic.sbe.otf.OtfHeaderDecoder;
import uk.co.real_logic.sbe.otf.OtfMessageDecoder;
import java.io.File;
import java.io.IOException;
import java.nio.ByteBuffer;
import java.nio.channels.FileChannel;
import java.nio.file.StandardOpenOption;
import java.util.ArrayDeque;
import java.util.Deque;
import java.util.List;
import static java.util.stream.Collectors.joining;
public class Bug
{
@Test
public void test() throws IOException
{
UnsafeBuffer buffer = new UnsafeBuffer(new byte[4096]);
MessageHeaderEncoder headerEncoder = new MessageHeaderEncoder();
ExecutionReportEncoder executionReportEncoder = new ExecutionReportEncoder();
executionReportEncoder.wrapAndApplyHeader(buffer, 0, headerEncoder);
executionReportEncoder.instructionId("abcdef");
executionReportEncoder.orderState().otherInstructionId("ghijk");
final ByteBuffer byteBuffer = readOrderBookEventsIr("/bug.sbeir");
Ir orderBookEventsIr = new IrDecoder(byteBuffer).decode();
OtfHeaderDecoder headerDecoder = new OtfHeaderDecoder(orderBookEventsIr.headerStructure());
final int blockLength = headerDecoder.getBlockLength(buffer, 0);
final int templateId = headerDecoder.getTemplateId(buffer, 0);
OtfMessageDecoder.decode(
buffer,
headerDecoder.encodedLength(),
209,
blockLength,
orderBookEventsIr.getMessage(templateId),
new AbstractTokenListener()
{
private final Deque<String> path = new ArrayDeque<>();
private int compositeDepth = 0;
@Override
public void onBeginComposite(final Token fieldToken, final List<Token> tokens, final int fromIndex, final int toIndex)
{
if (compositeDepth > 0)
{
path.addLast(tokens.get(fromIndex).name());
}
else
{
path.addLast(fieldToken.name());
}
compositeDepth++;
}
@Override
public void onEndComposite(final Token fieldToken, final List<Token> tokens, final int fromIndex, final int toIndex)
{
path.removeLast();
compositeDepth--;
}
@Override
public void onEncoding(final Token fieldToken, final DirectBuffer buffer, final int bufferIndex, final Token typeToken, final int actingVersion)
{
path.addLast(fieldToken.name());
System.out.printf("%s%n", path.stream().collect(joining(".")));
System.out.printf("fieldToken: %s%n", fieldToken);
System.out.printf("typeToken : %s%n", typeToken);
path.removeLast();
}
});
}
private ByteBuffer readOrderBookEventsIr(String s) throws IOException
{
FileChannel open = FileChannel.open(new File("bug.sbeir").toPath(), StandardOpenOption.READ);
return open.map(FileChannel.MapMode.READ_ONLY, 0, open.size());
}
}
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Milestone
Relationships
Development
Issue actions
You can’t perform that action at this time.