You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 2, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetVersionEx is deprecated and so will raise warning as errors. There were two case: in one it checked if on Windows Vista or later in the second if on Windows XP or later.
AFAICT the platforms supported are from Vista onwards: I removed the checks.
GdiPlus.h inclusion will raise some warnings so I disabled them
Nice to see someone working on the VS2015 support: it's one of the two pain points of not being able to contribute so much on the brackets-shell side π (Other one being that I don't have that much native coding experience but that's just a sidematter πΉ
The reason will be displayed to describe this comment to others. Learn more.
I simply deleted the old code and reindented.
I don't think there should be any dependency on VS2015.
The code was platform dependent, so if that platforms are not supported anymore should be fine both on VS2010 and VS2015 (I hope π )
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warnings fixed were:
AFAICT the platforms supported are from Vista onwards: I removed the checks.
/cc @nethip