Build fixes for Ubuntu18.04 (#649)

g-217 · swmitra · commit 7350d0b5fd1c · 2018-05-14T17:35:00.000+05:30
diff --git a/appshell/appshell_extensions_platform.cpp b/appshell/appshell_extensions_platform.cpp
@@ -7,6 +7,7 @@
 #include "appshell/browser/main_context.h"
 #include "appshell/browser/root_window_manager.h"
 #include "appshell/browser/root_window_gtk.h"
+#include <unicode/unistr.h>
 #endif
 
 #define UTF8_BOM "\xEF\xBB\xBF"
diff --git a/appshell/appshell_extensions_platform.h b/appshell/appshell_extensions_platform.h
@@ -33,6 +33,9 @@
 
 #ifdef OS_LINUX
 #include <gtk/gtk.h>
+#include <unicode/ucnv_err.h>
+#include <unicode/uenum.h>
+#include <unicode/localpointer.h>
 #endif
 
 // Extension error codes. These MUST be in sync with the error
diff --git a/appshell/browser/client_handler.cc b/appshell/browser/client_handler.cc
@@ -337,13 +337,17 @@ bool ClientHandler::OnDragEnter(CefRefPtr<CefBrowser> browser,
 }
 #endif
 
+#ifndef OS_LINUX
+//We do not plan to add any feature to parent class(::ClientHandler) implementation of this function.
+//So override is useless, modern compilers will complain about this.
 void ClientHandler::OnDraggableRegionsChanged(
     CefRefPtr<CefBrowser> browser,
     const std::vector<CefDraggableRegion>& regions) {
   CEF_REQUIRE_UI_THREAD();
 
   NotifyDraggableRegions(regions);
 }
+#endif
 
 bool ClientHandler::OnRequestGeolocationPermission(
       CefRefPtr<CefBrowser> browser,
diff --git a/appshell/browser/client_handler.h b/appshell/browser/client_handler.h
@@ -182,9 +182,13 @@ class ClientHandler :
                    CefDragHandler::DragOperationsMask mask) OVERRIDE;
   #endif
 
+#ifndef OS_LINUX
+//We do not plan to add any feature to parent class(::ClientHandler) implementation of this function.
+//So override is useless, modern compilers will complain about this.
   void OnDraggableRegionsChanged(
       CefRefPtr<CefBrowser> browser,
       const std::vector<CefDraggableRegion>& regions) OVERRIDE;
+#endif
 
   // CefGeolocationHandler methods
   bool OnRequestGeolocationPermission(
