| CARVIEW |
Select Language
HTTP/2 200
date: Tue, 15 Jul 2025 12:34:59 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=374.770118,conversation_content-fragment;desc="conversation_content fragment";dur=1532.09806,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=250.261729,nginx;desc="NGINX";dur=0.991888,glb;desc="GLB";dur=94.756908
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=MILbTAxyQTrSLyJFc%2F07vasV35tQZtfzjYrwXqVnbu3vTAohhktiZ3Zy8CMgXqPDWO10ydaKM%2FUunbex8XE2h0V2%2B%2BI%2Fm%2FjhGtxEOpcYlC7Dzg%2FWm7uCfiLyBhjx1nvDXiN9h0TMK%2FClhbkG68LptskfcZtDhHHR2KeBLCPoXwY6NNi3zceya0KwN95VFn3nbgpflaytws8YCOmxYm8LsT5wfMtLG3SRH2Rn%2BZ%2FBn%2FpT6QiqYnKzZ6JZBF4YhSDol5ZMn0whRAKZjTgqXQeu6Q%3D%3D--bJ%2FtIe8lNZ2y2hoi--r90zhm%2FToeWtZkPmp7yi0w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.209002918.1752582897; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 12:34:57 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 12:34:57 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: ADE0:27A670:8A3A3A:9B5317:68764AF1
Show JS parameter hint by dloverin · Pull Request #4637 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terHint. add unittests for HintUtils.formatParameterHint
Clean up unittests.js and change string from "<no arguments>" to "<no parameters>"
…terHint. add unittests for HintUtils.formatParameterHint
Clean up unittests.js and change string from "<no arguments>" to "<no parameters>"
…into fn-param-hints Conflicts: src/extensions/default/JavaScriptCodeHints/ParameterHintManager.js
|
@RaymondLim Here's the pull request. Please review. |
ghost
assigned
| $.when(fnTypePromise).done( | ||
| function (fnType) { | ||
| session.setFnType(fnType); | ||
| session.setFunctionCallPos(functionOffset); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to use "offset" here instead of "functionOffset" as it can be null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to use "functionOffset" because "offset" can be relative to a portion of the, not the top of the file. It's a bug for "functionOffset" to be null.
| top: 40px; | ||
| pointer-events: none; | ||
|
|
||
| padding: 1px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need more padding, at least 3px to the left and right of the hint so that text does not touch or too close to the border. Currently, it is harder to see the square brackets that denotes the optional parameter.
| * Given a Tern formatted function type string, convert it to an array of Objects, where each object describes | ||
| * a parameter. | ||
| * | ||
| * @param {String} newFnType - Tern formatted function type string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit: primitive type String should be in lowercase.
| if (type === "variable-2" || type === "variable" || type === "property") { | ||
| nextToken = self.getNextToken(localCursor, true); | ||
| if (nextToken && nextToken.string === "(") { | ||
| //nextToken = self.getNextToken(localCursor, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this commented code?
… Infer.expressionType() as suggested by marijn. The problem with this fix is it requires a "full" text update with the parameter hint request. Suggested a possible solution in the issue. The quality of the hints has been much improved and record type annotations can be hinted correctly.
This was referenced Aug 16, 2013
|
Merging now. I'll be submitting a new pull request to fix one unit test failure in JS Quick Edit caused by this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Implements a new command, "Show Parameter Hint".
Shows the parameters of a function and bolds the hint where the cursor is located. Automatically shows a parameter hint when a function is selection from the code hints dialog.
Current limitations:
1. no automatic parameter hint for selected hints that are "guesses".
2. no hint of record type annotations (Tern issue #207)
3. problem with optionals hints (fixed in latest Tern, issue #208)
4. Array. annotation shown as Array. (needs investigation).