Nice! One quick comment: "before/afterAll()" sound easily confusable with "before/afterEach()" to me. What about "beforeFirst()" and "afterLast()"?

"beforeFirst()" and "afterLast()" sound better. I went with "before/afterAll()" because I looked like the names jasmine could use to name the APIs, but it doesn't seem that they will add this functions to jasmine, so we could go with different names.

Reviewing

Initial review complete. I agree with @peterflynn on the naming. Thanks for working on this cleanup @TomMalbran!

@jasonsanjose Fixes pushed.

One think to notice is that when to chained suites have before or after all functions, the child suite functions will be called first, since we iterate from the spec parent to i'ts parents. Maybe this behavior could be reversed for the before first functions, having the outer most being called first and inner after.

@TomMalbran It's not an issue with the current usage, but I agree I think that running the highest ancestor beforeFirst callbacks before the lower ones is a good change to make. I'll merge this now and we can follow up later.