| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 06:03:13 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=434.447574,conversation_content-fragment;desc="conversation_content fragment";dur=993.599063,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=690.113019,nginx;desc="NGINX";dur=0.702731,glb;desc="GLB";dur=95.727711
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=o7%2BI7fhjGuF0Xuxm1vSDqTzk%2BipCVL%2BOF4EoTspFyi1T9tR6WpdSo2LpHcrTtSbTlMc5zFaBhGUVONgDc8L5qb3%2BvVfM0kLhLZngyE3%2FB2wK0grKwrh2SA8PrrNAWVUaN%2BnvFoKs%2F65uruk5cy2Ry2FbMMogWBaYwhj02odjBJF%2BPM83X90eoQw%2B8LvhbXiUSNHALvNMFjgW9ipVJTFEKNu2wVgDUO6yLhJCKLUoJLQGTCiMJO%2FDDOIP%2BW86Ou6xdw%2Fttfa3rKtGFFcYUDjoRQ%3D%3D--X41NNKJkEtnxKav%2F--oBlp0peUQdybZM7xagyidQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1206375516.1752904992; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 06:03:12 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 06:03:12 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 884A:3C3816:15E25F:1CC1F4:687B3520
Enhance status bar to show length of selection by peterflynn · Pull Request #4579 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Enhance status bar to show length of selection #4579
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line, line(s) or partial lines if selection spans more than one). Hoist out \t converion logic from EditorgetCursorPos(). Add unit tests for it.
ghost
assigned
| @@ -156,6 +156,8 @@ define({ | |||
| * StatusBar strings | |||
| */ | |||
| "STATUSBAR_CURSOR_POSITION" : "Line {0}, Column {1}", | |||
| "STATUSBAR_CH_SELECTION_LEN" : " \u2014 Selected {0} column(s)", | |||
| "STATUSBAR_LINE_SELECTION_LEN" : " \u2014 Selected {0} line(s)", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two strings have two things not consistent with total lines strings on line 167 and 168
"STATUSBAR_LINE_COUNT_SINGULAR" : "\u2014 {0} Line",
"STATUSBAR_LINE_COUNT_PLURAL" : "\u2014 {0} Lines",
Total line count strings do not have a preceding space and we're using separate string for singular and plural line count. So when you have some selection, Brackets is going to show the inconsistency with Selected n line(s) -- nnn lines
Regarding the leading space I wonder we should just concatenate the hard-coded string -- in the code rather than having the separator character and spaces in the localizable strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The separator is already used in STATUSBAR_LINE_COUNT_*, and I'm not sure if separators are ever locale-specific (quotation marks certainly are), so to be safe I'd prefer to leave it as-is for now.
I will fix the pluralization issue though.
|
Done first review. |
…ar - never use the indefinite "(s)" suffix anymore.
|
@RaymondLim Fix pushed. Do you think you could squeeze this in today? That way it can land before string freeze. (My fault if not, though -- sorry for the delay in responding!) |
| @@ -49,13 +49,17 @@ define(function (require, exports, module) { | |||
| $indentWidthInput; | |||
|
|
|||
|
|
|||
| function _formatCountable(number, singularStr, pluralStr) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be a nice StringUtils function. It is also missing the JSDocs. But lots of functions in this file have the same problem. Could be fixed later.
|
Looks good! Merging. |
RaymondLim
added a commit
that referenced
this pull request
Aug 6, 2013
Enhance status bar to show length of selection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Show length of selection when one is present -- number of cols if within a single line, number of lines (or partial lines) if selection spans more than one.
Hoists out "\t" conversion logic from Editor.getCursorPos(). Add unit tests for it.
If we're really not into putting this in core, this seems doable as an extension too... just not nearly as cleanly.