| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 06:38:33 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=360.759142,conversation_content-fragment;desc="conversation_content fragment";dur=771.079653,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=273.052723,nginx;desc="NGINX";dur=0.997907,glb;desc="GLB";dur=96.120973
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=dDWyx9y4o7TQOzjSSPZ%2FghhhZEPRuJmyqOGc3v9OkmpsZTEjhrW77MnDXglcniDwtmQf36%2B8r1ZQ2ILB2TQnqVWED7IXnaYCU3E0pfbSXmIW0ouLc9ojriIAprKx%2F1sNfwvlm%2FEzjZIte5CyeCrn%2B10lNeYbiuLgUYsVqjMTVUD5KwLbJJiNdOfZH2mvrh72MmG2a3h6RtJ1RqkH%2B1LVtSLtRBoFtHO6qVVnG4rANsC6wuyhAT4cffLhqZE3DGCuPVXGqxCrH55llXZfUNZqkg%3D%3D--PVhlNc4pVKvb4Aw%2B--bkDGiw6uMooB9oNaNFWLHw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.740315106.1752907112; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 06:38:32 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 06:38:32 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A638:2BEE38:1B0D0B:230233:687B3D68
Review fixes https://github.com/adobe/brackets/pull/4382 by shevchuk · Pull Request #4442 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Review fixes https://github.com/adobe/brackets/pull/4382 #4442
Merged
peterflynn
merged 2 commits into
adobe:master
from
shevchuk:hide-zipped-from-quick-open-review-1
Jul 22, 2013
Merged
Review fixes https://github.com/adobe/brackets/pull/4382 #4442
peterflynn
merged 2 commits into
adobe:master
from
shevchuk:hide-zipped-from-quick-open-review-1
Jul 22, 2013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Hi @shevchuk -- just FYI, in the future you can just push new commits up to the same branch and they'll get automatically included in the original pull request--no need to close it and reopen a new one. Thanks. |
|
Hi @njx, sorry, will absolutely follow your advice. |
|
No problem, thanks again for working on this. |
| * File names which are not showed in quick open dialog | ||
| * @type {RegExp} | ||
| */ | ||
| var _binaryExclusionListRegEx = /\.svgz$|^\.jsz$|^\.zip$|^\.gz$|^\.htmz$|^\.htmlz$|^\.rar$|^\.tar$|^\.exe$|^\.bin$/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't want the ^s here -- that means only ".zip" will match, not "foo.zip". The only reason the _exclusionListRegEx uses ^ is because it really is filtering out exact names in those cases (e.g. ".svn" isn't an extension, it's a complete folder name).
|
@shevchuk just two more comments (see above) and then we can merge |
|
@peterflynn thanks for pointing to that place that makes indices. |
|
@peterflynn finished, please review last commit |
|
Thanks @shevchuk, looks good! Merging now... |
peterflynn
added a commit
that referenced
this pull request
Jul 22, 2013
…view-1 Exclude certain known binary files types from FileIndexManager (and thus Quick Open, Find in Files, etc.)
|
Note: this is related to the larger user story for excluding things from search in general. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
@peterflynn here is a fix for you comments in #4382