You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have no issues with merging this, I'd then open PRs fixing one rule per PR so we can get to 0 errors eventually. Eslint's autofix feature would work great here where available, like missing semicolons.
With this grunt eslint and npm run eslint will do different things.
Could you simply define "eslint": "grunt eslint" without adding the .eslintignore file?
As @petetnt I like stricter ESLint checks.
@ficristo my brackets-eslint extension understands official .eslintignore but can't get this stuff from grunt, that's why I opted out for this file. Maybe we can do this the other way, fix grunt eslint to use .eslintignore ?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys, I'd like to build on this, introducing more rules to our eslint config AND fixing the breakages of currently set rules.
The current state of the codebase is quite bad,
npm run eslint
returns: