You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: the webpack approach for semver is taken from brackets-electron, where it's implemented and works well if dependencies (in this case semver) don't provide amd build that we need to use in the browser code
Note2: sorry the diff is quite hard to read because of all the deletes, reading through commits might be easier
src/extensibility/node is exported as a zip for the registry (see brackets-registry/deps), so it seems to me it needs to be a standalone project or at least we need some way to export the zip: from what I can tell this breaks it. @zaggino do you know how the zip is created? Or maybe @ingorichter or @redmunds.
I believe that src/extensibility is used by both Brackets and the Brackets Extension Registry, but I don't know the process from getting code onto the registry. @ingorichter Do you know?
we need to tar/gzip all the js files in brackets/src/extensibility/node/ to create the archive for the registry. Then someone with permissions needs to update the registry. I don't have permissions anymore to the server. Before that update, we need to make sure that the changes work locally before updating the live system. I once ran into issues on that system, since the node version might be pretty outdated again and therefore required node_modules might not like it.
@swmitra can someone at @adobe take care of the update for https://github.com/adobe/brackets-registry or can I get access to that machine and work on it? we need to work on getting this merged so we can fix bugs related to brackets not working properly behind a proxy server
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zaggino
force-pushed
the
zaggino/update-extension-manager-deps
branch
from
Replacement for #10372 to keep from commiting
node_modulesto git as we should really abandon that practice where possible.Related #12898
cc @ficristo
Note: the webpack approach for semver is taken from brackets-electron, where it's implemented and works well if dependencies (in this case semver) don't provide amd build that we need to use in the browser code
Note2: sorry the diff is quite hard to read because of all the deletes, reading through commits might be easier