You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to me you have used the commit of the CodeMirror repository instead of using the adobe/CodeMirro2: I am unable to update the submodule.
In future can you write in the commit message the version we are going to update? Thank you.
Sorry but I don't think I'll have much time this or the next week to review this PR.
I saw a couple of fixes about backtips on JS scripts on latest master of CodeMirror: I would really like to take them. People is doing more and more ES6 stuff.
So I see at least two options:
land this as is. I think CodeMirror is stable enough that if doesn't introduce new errors in the Brackets test suite should good to go. The 1.7 release was released recentish enough that I think we have enough time to verify eventual regressions. (And take another upgrade next months)
wait the next release and meanwhile continue to test this PR and fixing the current tests failures
/cc @petetnt@MiguelCastillo@zaggino if they have more thoughts.
(I don't know how were tested the previous versions so having other opinions is good regardless)
Just so you know, we usually update to some commit of CodeMirror, not necessarily to a release version (in-between versions of CodeMirror are usually stable as well), so we can take in these recent fixes without problems.
Our testing process is mostly just running all the unit tests, merging, and then looking out for regressions in the issue tracker.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #12609.
cc @ficristo
I ran Unit, Integration and Extension tests without new failures.