You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @AllThingsSmitty .
Chrome 43+ supports animation. as we are on cef 2623[49] this chage is ok to go on win and mac.
unfortunately, Linux versions are still on 1547[29] and does not have full support of the above as specified in the CEF docs.
Was this tested on the linux builds?
@abose Please keep in mind that these are only changes to the samples folder, which is never actually rendered inside our shell. So I think this change is fine, and we can totally expect our users to have adopted Chrome/Chromium 43+, Safari 9+ or Opera 30+. What do you think?
These projects should be used to test all the available features of Brackets so we should be sure everything works inside the editor too.
So, while I agree that for Live Preview this PR is fine, I was thinking that some feature like Quick Edit may not work correctly?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made to the sample CSS files