| CARVIEW |
Select Language
HTTP/2 302
date: Mon, 14 Jul 2025 21:55:03 GMT
content-length: 0
location: https://github.com/adobe/brackets/pull/2263
server-timing: nginx;desc="NGINX";dur=0.726045,glb;desc="GLB";dur=95.791111
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=0UchJnzEV0wo2aTY4BexA9Ib2tyXyKrJ1NsoriRArvlNup07a3J9oxT88BDQrOjWHC%2F8fYosjOqstMhhSW4y8LHSwE5a6lRnhqYDEshKTOCPJaRnpPepoz1gx2lxT2En9%2BxYE7aMW3xOrVGDOMzMUH8mFHpy88w%2B%2FhMlVru1JH2FRe%2FghY4s9CurctItVrahMft0floe75ASCl%2B52mL4xf1j4IG2D5QPp43fALpoHI7emxGWiwkL7k%2FD2u99Q9H10FJSU35JPYHXQAQo8BZGLQ%3D%3D--zj2w%2FJDmFHivFE1I--jLsCKcWDC3NTgRpIN2Yl9A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1765818391.1752530102; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 21:55:02 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 21:55:02 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E356:2ACC5F:9266B:D23FF:68757CB6
HTTP/2 200
date: Mon, 14 Jul 2025 21:55:04 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=342.059196,conversation_content-fragment;desc="conversation_content fragment";dur=1107.565212,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=253.993633,nginx;desc="NGINX";dur=1.312224,glb;desc="GLB";dur=96.01326
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: E356:2ACC5F:92691:D2433:68757CB6
HTML attributes code hinting filter by jbalsas · Pull Request #2263 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (unfiltered.length) { | ||
| if (filtered.length) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to filtered is ok for your if block, but it's not ok for other if blocks. Make sure you also adjust others.
|
Ooops... thanks! I don't know how did I miss that... Fixed, double-checked and changes pushed ;) |
ghost
assigned
| it("should not find attributes before the tag is opened", function () { | ||
| var pos = {"ch": 0, "line": 0}; | ||
| setContentAndUpdatePos(pos, | ||
| ['<html>', '<body>', '<div class="clearfix">'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our coding guideline is to use double quotes for all strings and the one nested inside then can use a single quote. So can you switch to double-quotes in all your test cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, no problem, will fix that.
I actually copy/pasted from one of the tests above and all the existing ones have the quotes inverted. Do you want me to change those as a bonus, or should we let them be for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please do change them if you don't mind.
|
@RaymondLim All the quotes have been updated (hopefully) and the I've modified and fixed the test. |
|
Looks good, merging now |
RaymondLim
added a commit
that referenced
this pull request
Dec 6, 2012
HTML attributes code hinting filter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This pull requests should cover some of this story about filtering code hints https://trello.com/card/code-hinting-filter/4f90a6d98f77505d7940ce88/592, in particular, filtering HTML attributes already used inside a tag.
It adds a new
getTagAttributesmethod insideHTMLUtilsthat compiles a list of all used attributes inside a tag. This list is then used insideAttrHintsto exclude the already used attributes from the complete list.