Merge pull request #9189 from Mark-Simulacrum/codeinspection-public-access

ingorichter · ingorichter · commit f03c901b8e3b · 2014-12-02T17:42:59.000-08:00
Change CodeInspection Public API to expose providers
diff --git a/src/language/CodeInspection.js b/src/language/CodeInspection.js
@@ -161,7 +161,7 @@ define(function (require, exports, module) {
      * @return ?{Array.<{name:string, scanFileAsync:?function(string, string):!{$.Promise}, scanFile:?function(string, string):?{errors:!Array, aborted:boolean}}>} provider
      */
     function getProvidersForPath(filePath) {
-        return _providers[LanguageManager.getLanguageForPath(filePath).getId()];
+        return _providers[LanguageManager.getLanguageForPath(filePath).getId()].slice(0) || [];
     }
 
     /**
@@ -645,9 +645,10 @@ define(function (require, exports, module) {
     exports._PREF_ASYNC_TIMEOUT     = PREF_ASYNC_TIMEOUT;
 
     // Public API
-    exports.register       = register;
-    exports.Type           = Type;
-    exports.toggleEnabled  = toggleEnabled;
-    exports.inspectFile    = inspectFile;
-    exports.requestRun     = run;
+    exports.register            = register;
+    exports.Type                = Type;
+    exports.toggleEnabled       = toggleEnabled;
+    exports.inspectFile         = inspectFile;
+    exports.requestRun          = run;
+    exports.getProvidersForPath = getProvidersForPath;
 });
diff --git a/test/spec/CodeInspection-test.js b/test/spec/CodeInspection-test.js
@@ -166,6 +166,23 @@ define(function (require, exports, module) {
                 });
             });
 
+            it("should get the correct linter given a file path", function () {
+                var codeInspector1 = createCodeInspector("text linter 1", successfulLintResult());
+                var codeInspector2 = createCodeInspector("text linter 2", successfulLintResult());
+
+                CodeInspection.register("javascript", codeInspector1);
+                CodeInspection.register("javascript", codeInspector2);
+
+                var providers = CodeInspection.getProvidersForPath("test.js");
+                expect(providers.length).toBe(2);
+                expect(providers[0]).toBe(codeInspector1);
+                expect(providers[1]).toBe(codeInspector2);
+            });
+
+            it("should return an empty array if no providers are registered", function () {
+                expect(CodeInspection.getProvidersForPath("test.js").length).toBe(0);
+            });
+
             it("should run two linters", function () {
                 var codeInspector1 = createCodeInspector("text linter 1", successfulLintResult());
                 var codeInspector2 = createCodeInspector("text linter 2", successfulLintResult());
