| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 16:56:36 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=1654.538362,conversation_content-fragment;desc="conversation_content fragment";dur=1509.020884,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=460.743989,nginx;desc="NGINX";dur=0.888818,glb;desc="GLB";dur=140.567903
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=1Y%2FpL5fW1KGcJHF1T5Gzg3NgyVTqU4MvIoTTGu40mZT1kEbVSIGpLBkAmKV1RQkU34sv%2F3WUfLCI2C7TwkgmxUjHVA5Gvyn%2FEKPQDeiU8BqoXOn9Ln37X3aoD5s4R%2BIDPdJONQpZOUg3%2F7hQnagNheNiamz1Y%2BBGywP8ivukR4rFjAG8ltK2wLUJ5c31SDrKNzajbdFzrcqLOSB9fD6t3IFO2zHhcbJH8Fvq95ZqH5B0pfFNhpRX64qd0bAX5I%2FBib3%2FBEEChhotTVIQiY1u%2Fw%3D%3D--RxLdQX73hh1mIjqm--J151RC7lHCP6riCGONbcSA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.218112463.1760201794; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 16:56:34 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 16:56:34 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 929E:2C8153:8A8F07:B5D3D1:68EA8C42
Cover Block: Add `E2E` Test for `FocalPointPicker` by im3dabasia · Pull Request #69077 · WordPress/gutenberg · GitHub
Cover Block: Add
Cover Block: Add
Mamaduka
added
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
[Block] Cover
Affects the Cover Block - used to display content laid over a background image
labels
Feb 9, 2025
im3dabasia
force-pushed
the
fix/add-e2e-test-for-cover-block
branch
from
May 27, 2025 10:55
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Cover Block: Add E2E Test for FocalPointPicker
#69077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
t-hamano
merged 8 commits into
WordPress:trunk
from
im3dabasia:fix/add-e2e-test-for-cover-block
May 27, 2025
Merged
Cover Block: Add E2E Test for FocalPointPicker
#69077
t-hamano
merged 8 commits into
WordPress:trunk
from
im3dabasia:fix/add-e2e-test-for-cover-block
May 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
[Type] Automated Testing
|
When you have a moment, could you please review this PR? |
t-hamano
reviewed
May 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I think the current test checks the behavior of the FocalPointPicker component itself, and does not seem to be related to the Cover block at all.
We should check that the values set in the focal point picker are correctly applied to the block.
So I think we need to check at least two things:
toMatchObject: Whether the focal point values are saved as attributes
toHaveCSS: Whether inline styles are added to block HTML
t-hamano
reviewed
May 26, 2025
im3dabasia
force-pushed
the
fix/add-e2e-test-for-cover-block
branch
from
7880ab1 to
251631b
Compare
t-hamano
approved these changes
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
* feat: Add e2e test for focal point picker in cover block * fix: Use existing editor API to select blocks * fix: Refactored to use Accessible selectors while selecting focalPointInputs * feat: Expect cover block to have updated focalPoint attributes * feat: Expect the visual DOM to have the CSS applied because of updates in focals * feat: Update the focal inputs to have different values for top and left * feat: Add toMatchObject for the check for attributes in core/cover * feat: Update frontend expect to have 30% in left object-position Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Cover
Affects the Cover Block - used to display content laid over a background image
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Closes: #29002
This PR adds an end-to-end (E2E) test to ensure the Focal Point Picker in the Cover block works correctly.
Why?
We've encountered regressions in the past related to the Cover block's Focal Point Picker (e.g., #28487). Currently, there is no E2E test coverage for this feature, so adding a test will help prevent future regressions.
How?
Testing Instructions
Run the test using the following command:
To run only this test, temporarily modify the test to use
.only()like this:For debugging, change headless to false in the playwright.config.js file to view the UI while the test runs.
Screencast
Screen.Recording.2025-02-06.at.5.08.46.PM.mov
Screenshot of the test cases for the Cover block. Observe the 8th test case, which has been added in this PR.