CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 14:16:11 GMT
content-type: text/html; charset=utf-8
cache-control: max-age=0, private, must-revalidate
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
link: ; rel=preload; as=fetch; crossorigin=use-credentials
referrer-policy: no-referrer-when-downgrade
server-timing: issue_layout-fragment;desc="issue_layout fragment";dur=316.507821,issue_conversation_content-fragment;desc="issue_conversation_content fragment";dur=627.11136,issue_conversation_sidebar-fragment;desc="issue_conversation_sidebar fragment";dur=47.378798,nginx;desc="NGINX";dur=1.109761,glb;desc="GLB";dur=100.932835
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With, Accept,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=kJR2XpkfMmD7JQL%2BGnpU0ZVNU%2FmgJztT3hWGHyMNWmzr4Z3lyyUJ8fY896Qswf0JN%2BDRKS3%2BoQ7%2F4XXqAynpsecSxhUSYtfr60IcViFBOrY13NGRPVBh90r4qqESXZBvbTLIMC%2BzTV8CpcbNqnQ3jPT5pmCQqfwFtScdnzmkmngx3QuKa3Z7zSpA5LgnLjojPqhcbEXBUXbUd7Ez42WwhLHVYxb407YjszThukoBjygArLC90XRMz988vnan6XC1kmALUMeWBSejsQbIj%2B%2FMcw%3D%3D--3AjaipJEbDxOg4vg--6Pp1BzdufIkYww0NoFNHYw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.48219761.1753366570; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 14:16:10 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 14:16:10 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: ACD2:1C1414:D754D:F4E86:6882402A
Eliminate Client and Server Builders · Issue #280 · ReactiveX/RxNetty · GitHub
No labelsNo typeNo projectsNone yetNo branches or pull requests
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 257
Closed
Milestone
Description
Today, all clients and servers follow the builder pattern to make sure that a client/server once created in immutable. In order to make the creation of most common clients/server easy, RxNetty
factory class has some factory methods, like:
public static RxServer<ByteBuf, ByteBuf> createTcpServer(final int port,
ConnectionHandler<ByteBuf, ByteBuf> connectionHandler);
public static HttpServer<ByteBuf, ByteBuf> createHttpServer(int port, RequestHandler<ByteBuf, ByteBuf> requestHandler);
It also has the following builder creation methods:
public static <I, O> ServerBuilder<I, O> newTcpServerBuilder(int port, ConnectionHandler<I, O> connectionHandler);
public static <I, O> HttpClientBuilder<I, O> newHttpClientBuilder(String host, int port);
The above two concepts are a bit odd as a user has to unlearn one to learn the other. eg: If one needs to enable wire-level logging, there is no way, one can do that while creating a client/server. One, has to use the builder.
Proposal
- Fold all builder methods into the main client/server. Every invocation of those methods, should create a new instance of client/server.
- Replace inheritance with delegation in clients/servers. In absence of this change, the client/server have to introduce a generic parameter which will guide what to return from these methods which create a new client/server. The downside is that an
HttpClient
can not be used as anRxClient
. The usage of this aspect is very limited as once, a user uses anHttpClient
, there is very little use of using#connect()
on the client.
After this change, users of a particular client/server would just have to be aware of any APIs on that client/server and nothing else. There will be less abstractions and less confusion.
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Milestone
Relationships
Development
Issue actions
You can’t perform that action at this time.