| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 20:29:00 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=310.81723,conversation_content-fragment;desc="conversation_content fragment";dur=638.2991,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=338.391637,nginx;desc="NGINX";dur=1.275207,glb;desc="GLB";dur=100.452275
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=hQVhEdxwP%2FQjeD2NGQwJynK%2Fe9PCM1Wej6EHnK3yynNvchaUlKhALHEBDteavLZYJqs9uOYmYws%2BwGgD2B0WSe9xe4CVmsj1VFtsL07sKa3DdY%2BvYi6TsQzIoGFElBrGXcBwbu5HZTGY16sEOCEWfo%2FybgvNgH8TZEUvppSrzkzo%2FW0D50pveHmLT6AJCzLGnfJ4dxElUWNnY3OrRzK56SYD0XLiqSo2gDb7C48HpvJJh%2B1PuMaWmQhnIDH9wwuKfbT1mcksGDyJgc2F8bzGkQ%3D%3D--yHdbhWHzdmeNv49h--Pdai%2BU3HPDO1n65XIPXN3A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.31813666.1753302539; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:28:59 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:28:59 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A648:0A76:6318D:84D44:6881460B
[SOT] Check without graph for fallback code only by SigureMo · Pull Request #73515 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT] Check without graph for fallback code only #73515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 1 commit into
PaddlePaddle:develop
from
cattidea:sot/check-without-graph-for-fallback-code-only
Jun 23, 2025
Merged
[SOT] Check without graph for fallback code only #73515
SigureMo
merged 1 commit into
PaddlePaddle:develop
from
cattidea:sot/check-without-graph-for-fallback-code-only
Jun 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses a bug in the step-counting mechanism for the fallback code path by restricting the condition to fallback cases only.
- Updated condition to check only for fallback (code is None and no graph exists)
- Removed the non-fallback branch that invoked eval_frame_default and callback update
- Adjusted the reference handling of disable_eval_frame
Comments suppressed due to low confidence (2)
paddle/fluid/pybind/sot/eval_frame.c:324
- The updated condition limits the check to fallback scenarios, omitting the early return via eval_frame_default and callback update. Please confirm that this removal is intentional and does not affect other fallback code paths.
if (code == Py_None && is_code_without_graph(PyFrame_GET_CODE(frame))) {
paddle/fluid/pybind/sot/eval_frame.c:325
- Since disable_eval_frame likely points to one of the singleton PyBool objects (Py_True or Py_False), review if the manual decref/incref is necessary to avoid potential reference mismanagement.
Py_DECREF(disable_eval_frame);
gouzil
approved these changes
Jun 21, 2025
|
拉分支后合 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
我们目前有一个策略，就是针对一个 code，如果连续多次都没有感知到其内有 graph，就直接回退到动态图，这个目前主要针对的应该是有 fallback 的场景，而对于非 fallback，也就是生成了 code 的场景，一般不会没有 graph，就算没有，也应该是在新的 code 里处理而不是在这里
目前处理方式是有问题的，
StepInfoManager是为每个 original code 来记录 step count，但实际记录的分别如下：这里两者 step 记录的不匹配导致出现如下问题
这里问题只出现在非 fallback 的情况，fallback 的情况因为记录的 code 是统一的，因此不会出问题
而非 fallback 的情况已经生成 code 了，一般不会没有 graph，因此本 PR 移除对该 case 的处理，仅针对 fallback case