| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 20:08:09 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=263.321542,conversation_content-fragment;desc="conversation_content fragment";dur=839.073266,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=335.772282,nginx;desc="NGINX";dur=1.09059,glb;desc="GLB";dur=100.845692
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=77zeR3NHQOGzleVHk1iltFhGLCZ%2BdIU1Kj2IznVOR6X6YTr2jCek5fu4Es9yGpl%2FX%2Fm%2Fxu16Rvv%2BaTph7lWE1%2Br3r1%2BIv%2BAsS%2BGILClihL6IKq8pDWIwh2XlNnG4cKL%2FHO3S43RXAuVpuEKoMUuZwv8wzNgKneiQTBsczYtoUNte9Wi7FOJusTUx1XeXNHc11JGrkU7rdpdviXfx1yNzf5qZ%2BoMGvp5YyIxZT8BV%2BXnkMtJuzYMJ%2Fs9%2FmaIctbbHjvvqxmpEFPPgbmr7RuO9qQ%3D%3D--pMzWqo6Z%2BsZtqAcu--UGsaZ68H1c1bI3OpSvy9%2FA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1153247076.1753301288; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:08:08 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:08:08 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 80A2:124FF4:10758D8:138CEA3:68814128
[SOT] Add `collections.namedtuple` support by SigureMo ยท Pull Request #72495 ยท PaddlePaddle/Paddle ยท GitHub
[SOT] Add
[SOT] Add
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT] Add collections.namedtuple support
#72495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zrr1999
merged 3 commits into
PaddlePaddle:develop
from
cattidea:sot/add-namedtuple-support
Apr 26, 2025
Merged
[SOT] Add collections.namedtuple support
#72495
zrr1999
merged 3 commits into
PaddlePaddle:develop
from
cattidea:sot/add-namedtuple-support
Apr 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ไฝ ็PRๆไบคๆๅ๏ผๆ่ฐขไฝ ๅฏนๅผๆบ้กน็ฎ็่ดก็ฎ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for collections.namedtuple to avoid OOM issues caused by holding tensor objects directly. The changes include new tests for namedtuple support, a helper function to identify namedtuple classes, and the introduction of new variable classes to correctly wrap and handle namedtuple instances.
- Added test cases in the SOT test suite.
- Introduced is_namedtuple_class in utils and exported it.
- Implemented NamedTupleVariable and NamedTupleClassVariable to support namedtuple operations.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/sot/test_collections_namedtuple.py | New tests ensuring namedtuple support and proper functionality with tensors. |
| python/paddle/jit/sot/utils/utils.py | Added is_namedtuple_class to detect namedtuple classes based on attributes. |
| python/paddle/jit/sot/utils/init.py | Exported is_namedtuple_class for usage in other modules. |
| python/paddle/jit/sot/opcode_translator/executor/virtual_frame.py | Removed temporary signature_clear_guard usages and updated locals population with fn_bind_inputs. |
| python/paddle/jit/sot/opcode_translator/executor/variables/container.py | Introduced NamedTupleVariable to wrap namedtuple instances. |
| python/paddle/jit/sot/opcode_translator/executor/variables/callable.py | Added NamedTupleClassVariable to support namedtuple classes. |
| python/paddle/jit/sot/opcode_translator/executor/variables/base.py | Reintroduced signature_clear_guard and updated fn_bind_inputs. |
python/paddle/jit/sot/opcode_translator/executor/variables/container.py
Outdated
Show resolved
Hide resolved
โฆtainer.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
zrr1999
approved these changes
Apr 26, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #72495 +/- ##
==========================================
Coverage ? 97.36%
==========================================
Files ? 5
Lines ? 76
Branches ? 0
==========================================
Hits ? 74
Misses ? 2
Partials ? 0 โ View full report in Codecov by Sentry. ๐ New features to boost your workflow:
|
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
* [SOT] Add namedtuple support * Update python/paddle/jit/sot/opcode_translator/executor/variables/container.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * refine type --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canโt perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
ๆทปๅ
collections.namedtupleๆฏๆ๏ผ้ฟๅ ๅ ถไธญๆๆ Tensor ๆถๅๅฏผ่ด OOM๏ผ่ฟไนๅๆฏObjectVariable๏ผๆฏ็ดๆฅๆๆ Tensor ็๏ผๅ็ปญ้่ฆๆณไธ็งๆนๆณ้ฟๅ ็ฑปไผผๆ ๅต