| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 02:58:50 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=287.437293,conversation_content-fragment;desc="conversation_content fragment";dur=1123.320835,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=323.358707,nginx;desc="NGINX";dur=1.288607,glb;desc="GLB";dur=101.192521
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=0euYpFJUKQNPO0jIBTUcFM6oqmhZWN4LfVphkaHZYcWD1fbdxpCjkWXY8YZ1S09gRYMRSvhO2C1h4cQeeDnIDIjFgsVgAZMDOhAxgpJanjLCJWMLZdNQL922LZf2weVSuI1T7xnicqLbiri8kFw%2BRP2Hgow8ed2y24%2FqqlK1lUVK1DbnwUjBd%2BZ8wRPFtKZM2ucBeSgN7Wnm4BsTpjHjgYql1pvAzKPK4eF8ZfZKYc7GonFPR7GPXxyhruYHt%2FYzLT7FiFVNCgbm02LeVcpfFA%3D%3D--iEP830zc8%2FCs6RJr--N22WKjHDxlUdZepWmRXzzw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1656492280.1753412328; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 02:58:48 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 02:58:48 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BAFC:144383:E3EB9:15743D:6882F2E8
[CINN]add variance op in frontend by Hongqing-work · Pull Request #71184 · PaddlePaddle/Paddle · GitHub
Hongqing-work
requested review from
xiaoguoguo626807,
JiabinYang and
phlrain
as code owners
February 18, 2025 10:24
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CINN]add variance op in frontend #71184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Hongqing-work
merged 2 commits into
PaddlePaddle:develop
from
Hongqing-work:add-frontend-variance
Feb 20, 2025
Merged
[CINN]add variance op in frontend #71184
Hongqing-work
merged 2 commits into
PaddlePaddle:develop
from
Hongqing-work:add-frontend-variance
Feb 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hongqing-work
requested review from
xiaoguoguo626807,
JiabinYang and
phlrain
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
lshpku
previously approved these changes
Feb 19, 2025
zyfncg
reviewed
Feb 19, 2025
Comment on lines
61
to
63
| if (fusion_op.GetOperators()[0]->isa<cinn::dialect::VarianceOp>()) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有kernel可以fallback了吧？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fallback之后性能会变差
Comment on lines
198
to
201
| auto cinn_reduce = rewriter.Build<cinn::dialect::VarianceOp>( | ||
| op->operand_source(0), axis, keepdim); | ||
| rewriter.ReplaceAllUsesWith(op.result(0), cinn_reduce.result(0)); | ||
| rewriter.EraseOp(op); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个op应该不用创建cinn的算子映射
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Comment on lines
25
to
36
| void VarianceKernel(const Context& dev_ctx, | ||
| const DenseTensor& x, | ||
| const IntArray& dims, | ||
| bool keep_dim, | ||
| DenseTensor* out) { | ||
| DenseTensor temp_mean = Mean<T, Context>(dev_ctx, x, dims, true); | ||
| DenseTensor temp_differences = Subtract<T, Context>(dev_ctx, x, temp_mean); | ||
| DenseTensor temp_pow = | ||
| Multiply<T, Context>(dev_ctx, temp_differences, temp_differences); | ||
|
|
||
| MeanKernel<T, Context>(dev_ctx, temp_pow, dims, keep_dim, out); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kernel实现放到.cc文件中
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Comment on lines
130
to
139
| - op : variance | ||
| args : (Tensor x, int64_t[] axis, bool keepdim) | ||
| output : Tensor(out) | ||
| infer_meta : | ||
| func : ReduceInferMeta | ||
| param : [x, axis, keepdim] | ||
| kernel : | ||
| func : frobenius_norm | ||
| param : [x, axis, keepdim] | ||
| interfaces : paddle::dialect::InferSymbolicShapeInterface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
和phi的算子完全一样，就不用加cinn的算子定义了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done，之前考虑的是把axis加成可变参数，现在只支持int64_t应该不需要cinn的op了
zyfncg
approved these changes
Feb 20, 2025
| @@ -431,6 +431,7 @@ CINN_REGISTER_HELPER(reduce_ops) { | |||
|
|
|||
| CINN_REGISTER_REDUCTION(reduce_sum, ReduceSum); | |||
| CINN_REGISTER_REDUCTION(reduce_prod, ReduceProd); | |||
| CINN_REGISTER_REDUCTION(variance, ReduceProd); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cinn里面最好也建一个对应op，至少语义对应上没问题
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
该替换放在后端改造部分的PR， 由@lshpku生效
xiaoguoguo626807
approved these changes
Feb 20, 2025
Enigmatisms
pushed a commit
to Enigmatisms/Paddle
that referenced
this pull request
Mar 6, 2025
* [CINN]add variance op in frontend * fix-comment
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
* [CINN]add variance op in frontend * fix-comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
Others
Description
pcard-67164
This PR adds variance op in frontend.