| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 22:45:00 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=346.290607,conversation_content-fragment;desc="conversation_content fragment";dur=1202.880292,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=314.527967,nginx;desc="NGINX";dur=0.937965,glb;desc="GLB";dur=101.037965
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=BxBCRjxCFu3e4us2AuAIldi4QR6qL7dh%2FS%2FPjVhker8pshDK2tmUyD6p9D2XciFQ7FpXxuopnrZvHLSAccOIvDurKvmw76gXqFOaNCdLB%2FTXu3B9nBy721zPEQqN2upUx55A3TlhSUp2reHsY8BWeLCvY5t3qpODxpXovzfnBze87207s19RQ8IgJAPKLGYhxoEHTlflImwMrxnszhvteiBygt6XW9AlImVF8vDEkG7vFAWTdIyo6LyvdjFL1u4Me2J2I%2B8MgOYmw4C%2BLdOZPQ%3D%3D--OOtT7hqKd3SuJlDI--e1quOlZoM0MZ7i88nicS8w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.103129606.1753656298; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 22:44:58 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 22:44:58 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C5F0:0A61:868225:B15AE2:6886ABEA
[SOT] Move Internal Function to External Scope by DrRyanHuang · Pull Request #71144 · PaddlePaddle/Paddle · GitHub
SigureMo
changed the title
[SOT] Move Internal Function to External Scope
[SOT][3.13] Move Internal Function to External Scope
Feb 18, 2025
DrRyanHuang
changed the title
[SOT][3.13] Move Internal Function to External Scope
[SOT] Move Internal Function to External Scope
Feb 19, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT] Move Internal Function to External Scope #71144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Feb 18, 2025
python/paddle/jit/sot/opcode_translator/executor/function_graph.py
Outdated
Show resolved
Hide resolved
python/paddle/jit/sot/opcode_translator/executor/function_graph.py
Outdated
Show resolved
Hide resolved
Comment on lines
881
to
887
| if self.is_graph_output(var): | ||
| return [var] | ||
| else: | ||
| retval = [] | ||
| for inp in var.tracker.inputs: | ||
| retval.extend(self.collect_related_dummy_tensor(inp)) | ||
| return retval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| if self.is_graph_output(var): | |
| return [var] | |
| else: | |
| retval = [] | |
| for inp in var.tracker.inputs: | |
| retval.extend(self.collect_related_dummy_tensor(inp)) | |
| return retval | |
| if self.is_graph_output(var): | |
| return [var] | |
| retval = [] | |
| for inp in var.tracker.inputs: | |
| retval.extend(self.collect_related_dummy_tensor(inp)) | |
| return retval |
在有 early return 的情况下不需要写 else 分支，可以大幅减少缩进
以下是一些常见 pattern：
if cond:
short_branch_stmts
return
else:
long_branch_stmts
return
# ->
if cond:
short_branch_stmts
return
long_branch_stmts
return
# ---
if cond:
long_branch_stmts
return
else:
short_branch_stmts
return
# ->
if not cond:
short_branch_stmts
return
long_branch_stmts
return
# ---
while cond1:
if cond2:
short_branch_stmts
else:
long_branch_stmts
# ->
while cond1:
if cond2:
short_branch_stmts
continue
long_branch_stmts这个函数看起来可以应用两次这个 rule
python/paddle/jit/sot/opcode_translator/executor/function_graph.py
Outdated
Show resolved
Hide resolved
SigureMo
previously approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
SigureMo
reviewed
Feb 18, 2025
SigureMo
changed the title
DrRyanHuang
changed the title
SigureMo
approved these changes
Feb 20, 2025
Enigmatisms
pushed a commit
to Enigmatisms/Paddle
that referenced
this pull request
Mar 6, 2025
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Improvements
Description
Move the internally defined function
is_graph_output&collect_related_dummy_tensorto external scope for better organization and reusability.PCard-66972