| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 23:50:27 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=284.33977,conversation_content-fragment;desc="conversation_content fragment";dur=1571.015345,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=342.757181,nginx;desc="NGINX";dur=1.191123,glb;desc="GLB";dur=100.714117
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=EJHNzL97Xxs%2FQ98VPtwDFznffADpxN4HgMKYS2byWRfCgcBDFuweWm4BzKcJj3dmvsuhVgfDKPY1dYXRu4CJdXUQSB2KK3%2FTe9dtJqkQ4KYRu112dbJtJ73TYt5yhV44qsOzzj%2Bom1tKLB%2BTA3fuD46wyn5R3hYMBhHK6MlnVxF%2B1x6vuw27Lg7OaCC8CcldMxr%2FSN30RKwsK6wvTjnh%2BLZ%2F5aa8eLRf4tixQqnBCJkfdsXcwIX0ufHa6%2F3MDfTZvx31DF0wwQa%2BS7bJvHYZUg%3D%3D--aCPsaNlK%2F7CxmYjD--ouKKn0rlCk3RQs4l8p25MA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.209952495.1753660225; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 23:50:25 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 23:50:25 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A312:3467EF:1238B29:1810CC6:6886BB41
[CINN] Add InferSymbolicShape Interface for `add_n_array` op by ooooo-create · Pull Request #69698 · PaddlePaddle/Paddle · GitHub
[CINN] Add InferSymbolicShape Interface for
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CINN] Add InferSymbolicShape Interface for add_n_array op
#69698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ooooo-create
commented
Nov 26, 2024
| @@ -2167,6 +2194,12 @@ bool ArrayWrite_Op::InferSymbolicShape( | |||
| out(), | |||
| symbol::ShapeOrDataDimExprs{ | |||
| symbol::RankedTensorArrayShapeOrDataDimExprs(x_shape)}); | |||
| // update array's shape as x's shape. | |||
| // TOOD(ooooo) Do not change if shape is set by custom, similar to infer_meta | |||
| infer_context->SetShapeOrDataForValue( | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我自行打开的单测，应该设置了也没用，因为从后面 Value 往前向查找的时候，并不会从 defineop 溯源中产生这个调用链，应该也就不会更新 array shape
x0 = pd_op.create_array(xxx)
x1 = pd_op.array_write_(x0,t1,?)
x2 = array_read(x0,?)
从 x2 开始验证推导结果
main_program
{
(%0) = "pd_op.data" () {dtype:(pd_op.DataType)float32,name:"d0",place:(pd_op.Place)Place(undefined:0),shape:(pd_op.IntArray)[10],stop_gradient:[true]} : () -> builtin.tensor<10xf32>
(%1) = "pd_op.data" () {dtype:(pd_op.DataType)float32,name:"d1",place:(pd_op.Place)Place(undefined:0),shape:(pd_op.IntArray)[10],stop_gradient:[true]} : () -> builtin.tensor<10xf32>
(%2) = "pd_op.full" () {dtype:(pd_op.DataType)int64,place:(pd_op.Place)Place(undefined:0),shape:(pd_op.IntArray)[1],stop_gradient:[true],value:(Double)0} : () -> builtin.tensor<1xi64>
(%3) = "pd_op.create_array" () {dtype:(pd_op.DataType)float32,stop_gradient:[true]} : () -> pd_op.tensor_array<f32>
(%4) = "pd_op.cast" (%0) {dtype:(pd_op.DataType)float32,stop_gradient:[true]} : (builtin.tensor<10xf32>) -> builtin.tensor<10xf32>
(%5) = "pd_op.array_write_" (%3, %4, %2) {} : (pd_op.tensor_array<f32>, builtin.tensor<10xf32>, builtin.tensor<1xi64>) -> pd_op.tensor_array<f32>
(%6) = "pd_op.increment_" (%2) {stop_gradient:[true],value:(Float)1} : (builtin.tensor<1xi64>) -> builtin.tensor<1xi64>
(%7) = "pd_op.cast" (%1) {dtype:(pd_op.DataType)float32,stop_gradient:[true]} : (builtin.tensor<10xf32>) -> builtin.tensor<10xf32>
(%8) = "pd_op.array_write_" (%3, %7, %2) {} : (pd_op.tensor_array<f32>, builtin.tensor<10xf32>, builtin.tensor<1xi64>) -> pd_op.tensor_array<f32>
(%9) = "pd_op.create_array_like" (%3) {stop_gradient:[true],val:(Float)0} : (pd_op.tensor_array<f32>) -> pd_op.tensor_array<f32>
(%10) = "pd_op.array_read" (%9, %2) {stop_gradient:[true]} : (pd_op.tensor_array<f32>, builtin.tensor<1xi64>) -> builtin.tensor<-1xf32>
(%11) = "pd_op.cast" (%0) {dtype:(pd_op.DataType)float32,stop_gradient:[true]} : (builtin.tensor<10xf32>) -> builtin.tensor<10xf32>
(%12) = "pd_op.array_write_" (%9, %11, %2) {} : (pd_op.tensor_array<f32>, builtin.tensor<10xf32>, builtin.tensor<1xi64>) -> pd_op.tensor_array<f32>
(%13) = "pd_op.increment_" (%2) {stop_gradient:[true],value:(Float)-1} : (builtin.tensor<1xi64>) -> builtin.tensor<1xi64>
(%14) = "pd_op.cast" (%1) {dtype:(pd_op.DataType)float32,stop_gradient:[true]} : (builtin.tensor<10xf32>) -> builtin.tensor<10xf32>
(%15) = "pd_op.array_write_" (%9, %14, %2) {} : (pd_op.tensor_array<f32>, builtin.tensor<10xf32>, builtin.tensor<1xi64>) -> pd_op.tensor_array<f32>
(%16) = "builtin.combine" (%3, %9) {stop_gradient:[true]} : (pd_op.tensor_array<f32>, pd_op.tensor_array<f32>) -> vec[pd_op.tensor_array<f32>,pd_op.tensor_array<f32>]
(%17) = "pd_op.add_n_array" (%16) {stop_gradient:[true]} : (vec[pd_op.tensor_array<f32>,pd_op.tensor_array<f32>]) -> pd_op.tensor_array<f32>
(%18) = "pd_op.array_read" (%17, %2) {stop_gradient:[true]} : (pd_op.tensor_array<f32>, builtin.tensor<1xi64>) -> builtin.tensor<-1xf32>
(%19) = "pd_op.increment_" (%2) {stop_gradient:[true],value:(Float)1} : (builtin.tensor<1xi64>) -> builtin.tensor<1xi64>
(%20) = "pd_op.array_read" (%17, %2) {stop_gradient:[true]} : (pd_op.tensor_array<f32>, builtin.tensor<1xi64>) -> builtin.tensor<-1xf32>
}
zyfncg
reviewed
Nov 27, 2024
| return true; | ||
| infer_context->SetShapeOrDataForValue( | ||
| op->result(0), | ||
| symbol::ShapeOrDataDimExprs{symbol::NullShapeOrDataDimExpr()}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
设置NullShapeOrDataDimExpr语义上是否合理？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
目前有的语义都不太合理，新增一个 RankedTensorArrayListShapeOrDataDimExprs 的 Value 符号表示是应该合理的。但是当前只有 combineop 和 addnaary 两者绑定的使用场景。现在并没有新增，而是 addnaary 的推导依赖于 combine op 的输入 Value。这里设置什么是不重要的，目前不会作为其他 Value 的推导依赖，好像设置只是保证了推导的过程不会因为 有符号推导接口的 op result 中 非 fake value 没有 shape_or_data 而抛出异常
ooooo-create
commented
Nov 27, 2024
| @@ -1495,6 +1516,7 @@ std::vector<pir::Type> CreateArrayOp::InferMeta( | |||
|
|
|||
| bool CreateArrayOp::InferSymbolicShape( | |||
| pir::InferSymbolicShapeContext *infer_context) { | |||
| // TODO(ooooo): Try to use output type's dims to decide. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下面的 symbol::RankedTensorArrayShapeOrDataDimExprs(std::vectorsymbol::DimExpr{}) 语义也是不明确的，语义上表示的当前 TensorArray 中没有元素，歧义的是也可以代表里面装的是 0D Tensor。在 infer_meta 里面有个 TODO, infer_meta 里设置的是 {0}，也有点不一致
一般创建空的 tensorarray ，后面 infer_meta 里 array_write_ 都会重新设置 dims，所以可以尝试 outputtype 的 dim 来更新,本地编译太慢，可以另起pr
Hongqing-work
previously approved these changes
Nov 29, 2024
Comment on lines
88
to
91
| infer_context->SetShapeOrDataForValue( | ||
| op->result(0), | ||
| symbol::ShapeOrDataDimExprs{symbol::NullShapeOrDataDimExpr()}); | ||
| return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对，设置有的语义都不合理，先不设置吧（无法处理combine_op的TensorArray类型输出被别的Op使用的情况）
zyfncg
approved these changes
Dec 3, 2024
gongshaotian
added a commit
to gongshaotian/Paddle
that referenced
this pull request
Dec 3, 2024
…addlePaddle#69698)" This reverts commit 16dbf47.
ooooo-create
added a commit
to ooooo-create/Paddle
that referenced
this pull request
Dec 3, 2024
…addlePaddle#69698)" This reverts commit 16dbf47.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
CINN
PR Types
Others
Description
add_n_arrayop在 pir 下，add_n_array 的输入是 CombineOp 的输出
Paddle/paddle/fluid/pir/dialect/operator/ir/manual_api.cc
Lines 240 to 247 in 6a4e651