CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 22:50:51 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=517.721804,conversation_content-fragment;desc="conversation_content fragment";dur=606.433012,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=328.356893,nginx;desc="NGINX";dur=1.039254,glb;desc="GLB";dur=101.942372
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ZpMeJIGWqO0FaG9PNBvSPPd3YT9LSMvx8Nb9Pl8hrspNra%2F0XRE2lOYhFRngLu56d14ihyMGpkw5AxU7JGWR1PlcP6jz82CTZ0KdlerEUFLF2%2FaktnIukMiUj63uSfJ5I%2FVGZj%2FbsMEdWHx%2F8f5xlBnKWZeKzM4ivsovd9AWC%2Fk%2FAYIm5NnOgipDcaODYbHpR13Q88H5q1AVfi6QenkeZ2sRTk06E%2BdvlTPthV9yV70lAPGS8E4NuKh64hA6lEOsWjl5lnSYFPhHfoXegz6wRQ%3D%3D--19s5E9XDM3Y0VRMs--Rxh01soYp5qz9FkhR3mxJA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2092731916.1753656650; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 22:50:50 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 22:50:50 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9906:3B05D7:11EC25A:17A59D0:6886AD4A
[PIR] speed up set device id by wanghuancoder · Pull Request #69676 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[PIR] speed up set device id #69676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wanghuancoder
merged 9 commits into
PaddlePaddle:develop
from
wanghuancoder:refine_set_device2
Nov 28, 2024
Merged
[PIR] speed up set device id #69676
wanghuancoder
merged 9 commits into
PaddlePaddle:develop
from
wanghuancoder:refine_set_device2
Nov 28, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
… refine_set_device2
zhiqiu
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Performance
Description
通过火焰图发现,PIR执行器每个Instruction都调用SetDeviceID影响调度性能尝试优化。且发现:Program InterpretorCore、动态图、老动态图均如此处理。
#69669 尝试通过ID值再本地保存一份做剪枝,且将所有cudaSetDevice全部替换为剪枝函数,虽然性能优化效果好,但大量单测崩溃。放弃。
本PR通过先cudaGetDevice的方式剪枝。局部性能可以提升60%以上。
Pcard-67164
业界也有相关的一些讨论:
pytorch/pytorch#18048
pytorch/pytorch#13974
pytorch/pytorch#13269
pytorch/pytorch#28639
OpenNMT/CTranslate2#1127
cupy/cupy#2608
https://github.com/pytorch/pytorch/pull/13741/files
https://forums.developer.nvidia.com/t/cudasetdevice-time-so-weird-cudasetdevice-take-a-long-time/18026
结论是:大家都发现cudaSetDevice、cudaGetDevice调用频率高,且浪费了调度性能。但是浪费的不够多,优化又没有好的办法,需要改动的实在太多,挑战框架设计。因此都没有实际认真优化。Torch当前的实现基本都是对cudaSetDevice做剪枝: