| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 22:48:56 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=291.867392,conversation_content-fragment;desc="conversation_content fragment";dur=971.633086,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=378.652603,nginx;desc="NGINX";dur=1.083075,glb;desc="GLB";dur=100.884979
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=lGPDjSeYNnOBh3LPLMkUNjI789k5FtcFKdgWMM5lbi%2F7Et2pA1w7bmTlp7YnRu1CUGnIFX7V%2FHcgeqdciMd0PrOnIuzIOY0iiiKskGOBnDO6twphOevpm20kCYzSND6xHkwY%2BU7mpyHQSekrdersYlIP7aPPgNj%2BQfAwL%2FSPzyuFDkniDUcQSsIaTGqEvBN1i9MBHmBXmnhKvX1Rb%2FExbGKMQBZEdJd39KEaFDgYsfyuhCYvnfCngVuPU9GY8p0BEZclAopqnQlAEk%2B6kmOoHg%3D%3D--%2F1CSFjjVSGOckukK--bP48bP74TwIsmxAObcghAQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2006668036.1753656535; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 22:48:55 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 22:48:55 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 814C:22FFCB:408ACA:550EC4:6886ACD7
[PIR] add shape64 op by wanghuancoder · Pull Request #69589 · PaddlePaddle/Paddle · GitHub
wanghuancoder
requested review from
SigureMo,
zrr1999 and
gouzil
as code owners
November 21, 2024 09:22
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[PIR] add shape64 op #69589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wanghuancoder
merged 30 commits into
PaddlePaddle:develop
from
wanghuancoder:shape_op_int64_2
Nov 27, 2024
Merged
[PIR] add shape64 op #69589
wanghuancoder
merged 30 commits into
PaddlePaddle:develop
from
wanghuancoder:shape_op_int64_2
Nov 27, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shape_op_int64
wanghuancoder
requested review from
SigureMo,
zrr1999 and
gouzil
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
… shape_op_int64_2
xiaoguoguo626807
previously approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFTM for prim
luotao1
approved these changes
Nov 27, 2024
jzhang533
reviewed
Nov 27, 2024
| @@ -109,7 +109,7 @@ def shape(input: Tensor) -> Tensor: | |||
| [array([ 3, 100, 100], dtype=int32)] | |||
| """ | |||
| if in_dynamic_or_pir_mode(): | |||
| out = _C_ops.shape(input) # type: ignore | |||
| out = _C_ops.shape64(input) # type: ignore | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a runtime warning to alert users of this behavioral change?
Additionally, should we include a warning message within the _C_ops.shape implementation to promote the use of shape64?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 这个修改，如果不崩溃，那么对用户无感就好。就等同于一个Kernel的性能优化。存量模型如果崩溃则自然用户需要修改。
- _C_ops.shape原则上确实不应该再被主动调用了。但是_C_ops.xxx本身不属于API，本身就不允许使用的。而这个API本身就不是常用API，如此高阶用法我认为是不存在的。
This was referenced Nov 27, 2024
Merged
This was referenced Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Improvements
Description
背景：
因此：添加shape64 OP，在框架中全量替代老的shape op。
之所以没有删除shape op的原因为：
问题1：模型组网中以int32使用了shape op，会挂掉。无论是PIR执行器还是Program执行器都存在这一场景。这种情况需要先修改模型组网，再Save才能修复。
问题2：新IR下，save了IR。因为IR中已经做了dtype的infermeta推断，所以save了很多int32的信息。to_kernel_pass会延用这一推断的信息，会导致ChooseKernel是错的。这种情况需要将模型，用最新的develop重新Save一遍，才能修复。
如果增加shape64，而不删除shape可以做到：
Pcard-67164