[SOT][3.13] Complete simulation for bytecode `TO_BOOL` `MAKE_FUNCTION` and `SET_FUNCTION_ATTRIBUTE` #69567

GoldenStain · 2024-11-20T18:11:31Z

PR Category

Execute Infrastructure

PR Types

Others

Description

实现了对TO_BOOL MAKE_FUNCTION 以及 SET_FUNCTION_ATTRIBUTE的模拟执行逻辑，TO_BOOL的代码生成部分尚未完成

PCard-66972

paddle-bot · 2024-11-20T18:11:39Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

GoldenStain · 2024-11-20T18:20:38Z

关于闭包的段错误：

3.13会发生段错误

grep: warning: GREP_OPTIONS is deprecated; please use an alias or script
[Cost Model] New step start, current state is StepState.RUN_SOT
[eval_frame_callback] start to translate: <code object set_function at 0x7f6eabcb46c0, file "/workspace/Paddle/test/sot/test_23_set_function_attribute.py", line 26>
[eval_frame_callback] OriginCode: set_function
  --           MAKE_CELL                0 (x)
  26           RESUME                   0
  27           LOAD_FAST                0 (x)
               BUILD_TUPLE              1
               LOAD_CONST               1 (<code object inner_function at 0x7f6eabce9ed0, file "/workspace/Paddle/test/sot/test_23_set_function_attribute.py", line 27>)
               MAKE_FUNCTION
               SET_FUNCTION_ATTRIBUTE   8 (closure)
               STORE_FAST               1 (inner_function)
  29           LOAD_DEREF               0 (x)
               LOAD_CONST               2 (1)
               BINARY_OP                0 (+)
               STORE_DEREF              0 (x)
  30           LOAD_DEREF               0 (x)
               RETURN_VALUE
Disassembly of <code object inner_function at 0x7f6eabce9ed0, file "/workspace/Paddle/test/sot/test_23_set_function_attribute.py", line 27>:
  --           COPY_FREE_VARS           1
  27           RESUME                   0
  28           LOAD_DEREF               4 (x)
               STORE_FAST               3 (y)
               RETURN_CONST             0 (None)
[Cache]: Firstly call <code object set_function at 0x7f6eabcb46c0, file "/workspace/Paddle/test/sot/test_23_set_function_attribute.py", line 26>
[Executor] code options: co_cellvars=('x',)
--------------------------------------
C++ Traceback (most recent call last):
--------------------------------------
No stack trace in paddle, may be caused by external reasons.
----------------------
Error Message Summary:
----------------------
FatalError: `Segmentation fault` is detected by the operating system.
  [TimeInfo: *** Aborted at 1732107650 (unix time) try "date -d @1732107650" if you are using GNU date ***]
  [SignalInfo: *** SIGSEGV (@0x500000159) received by PID 40529 (TID 0x7f6eac4a7500) from PID 345 ***]

3.10不会发生段错误

grep: warning: GREP_OPTIONS is deprecated; please use an alias or script
[Cost Model] New step start, current state is StepState.RUN_SOT
[eval_frame_callback] start to translate: <code object set_function at 0x7f95ae8b63f0, file "/workspace/Paddle/build_310/test/sot/test_23_set_function_attribute.py", line 26>
[eval_frame_callback] OriginCode: set_function
 27           0 LOAD_CONST              13 ((3, 5))
              2 LOAD_CONST               3 (5.0)
              4 LOAD_CONST               4 (('d',))
              6 BUILD_CONST_KEY_MAP      1
              8 LOAD_CONST              14 (('b', 'int', 'c', 'int', 'd', 'float'))
             10 LOAD_CONST              10 (<code object inner_function at 0x7f95ae8b58f0, file "/workspace/Paddle/build_310/test/sot/test_23_set_function_attribute.py", line 27>)
             12 LOAD_CONST              11 ('set_function.<locals>.inner_function')
             14 MAKE_FUNCTION            7 (defaults, kwdefaults, annotations)
             16 STORE_FAST               1 (inner_function)
 29          18 LOAD_FAST                0 (x)
             20 LOAD_CONST              12 (1)
             22 BINARY_ADD
             24 STORE_FAST               0 (x)
 30          26 LOAD_FAST                0 (x)
             28 RETURN_VALUE
Disassembly of <code object inner_function at 0x7f95ae8b58f0, file "/workspace/Paddle/build_310/test/sot/test_23_set_function_attribute.py", line 27>:
 28           0 LOAD_CONST               0 (None)
              2 RETURN_VALUE
[Cache]: Firstly call <code object set_function at 0x7f95ae8b63f0, file "/workspace/Paddle/build_310/test/sot/test_23_set_function_attribute.py", line 26>
[Executor] code options: co_cellvars=()
[EXECUTOR RUN] Start execute opcode: <code object set_function at 0x7f95ae8b63f0, file "/workspace/Paddle/build_310/test/sot/test_23_set_function_attribute.py", line 26>
[Translate Executor]: (line  27) LOAD_CONST   (3, 5), stack is []
[Translate Executor]: (line  27) LOAD_CONST   5.0, stack is [TupleVariable(2, tmp_var, object_173)]
[Translate Executor]: (line  27) LOAD_CONST   ('d',), stack is [TupleVariable(2, tmp_var, object_173), ConstantVariable(5.0, 5.0, object_162)]
[Translate Executor]: (line  27) BUILD_CONST_KEY_MAP 1, stack is [TupleVariable(2, tmp_var, object_173), ConstantVariable(5.0, 5.0, object_162), TupleVariable(1, tmp_var, object_163)]
[Translate Executor]: (line  27) LOAD_CONST   ('b', 'int', 'c', 'int', 'd', 'float'), stack is [TupleVariable(2, tmp_var, object_173), DictVariable(1, tmp_var_d_5.0, object_184)]
[Translate Executor]: (line  27) LOAD_CONST   <code object inner_function at 0x7f95ae8b58f0, file "/workspace/Paddle/build_310/test/sot/test_23_set_function_attribute.py", line 27>, stack is [TupleVariable(2, tmp_var, object_173), DictVariable(1, tmp_var_d_5.0, object_184), TupleVariable(6, tmp_var, object_176)]
[Translate Executor]: (line  27) LOAD_CONST   set_function.<locals>.inner_function, stack is [TupleVariable(2, tmp_var, object_173), DictVariable(1, tmp_var_d_5.0, object_184), TupleVariable(6, tmp_var, object_176), ObjectVariable(<code object inner_function at 0x7f95ae8b58f0, file "/workspace/Paddle/build_310/test/sot/test_23_set_function_attribute.py", line 27>, tmp_var, object_170)]
[Translate Executor]: (line  27) MAKE_FUNCTION 7, stack is [TupleVariable(2, tmp_var, object_173), DictVariable(1, tmp_var_d_5.0, object_184), TupleVariable(6, tmp_var, object_176), ObjectVariable(<code object inner_function at 0x7f95ae8b58f0, file "/workspace/Paddle/build_310/test/sot/test_23_set_function_attribute.py", line 27>, tmp_var, object_170), ConstantVariable(set_function.<locals>.inner_function, set_function.<locals>.inner_function, object_171)]
[Translate Executor]: (line  27) STORE_FAST   inner_function, stack is [UserDefinedFunctionVariable(set_function.<locals>.inner_function, tmp_var_set_function.<locals>.inner_function_tmp_var_tmp_var_tmp_var_d_5.0_tmp_var, object_204)]
[Translate Executor]: (line  29) LOAD_FAST    x, stack is []
[Translate Executor]: (line  29) LOAD_CONST   1, stack is [TensorVariable([], int64, True, var_0, x, object_0)]
[Translate Executor]: (line  29) BINARY_ADD   None, stack is [TensorVariable([], int64, True, var_0, x, object_0), ConstantVariable(1, 1, object_172)]
/workspace/Paddle/build_310/python/paddle/pir/math_op_patch.py:180: UserWarning: Value do not have 'place' interface for pir graph mode, try not to use it. None will be returned.
  warnings.warn(
         inputs : ((var_0, 1), {}) 
[Translate Executor]: (line  29) STORE_FAST   x, stack is [TensorVariable([], int64, True, var_1, tmp_var_x_1, object_206)]
[Translate Executor]: (line  30) LOAD_FAST    x, stack is []
[Translate Executor]: (line  30) RETURN_VALUE None, stack is [TensorVariable([], int64, True, var_1, x, object_206)]
start subgraph compile and execution.
StatementIR: SIR_0
  inputs: ['var_0']
  outputs: ['var_1']
  statements: 
    method     || var_1 = __add__ (var_0)  
[Guard]: lambda frame: len(frame.f_locals['x'].shape) == 0 and frame.f_locals['x'].dtype == paddle.core.DataType(9) and frame.f_locals['x'].stop_gradient == True
[EXECUTOR RUN] End execute opcode: <code object set_function at 0x7f95ae8b63f0, file "/workspace/Paddle/build_310/test/sot/test_23_set_function_attribute.py", line 26>
[eval_frame_callback] NewCode: #set_function_84ae0
 26           0 LOAD_GLOBAL              0 (paddle_set_eval_frame_fn)
              2 LOAD_CONST               0 (None)
              4 CALL_FUNCTION            1
              6 STORE_FAST               2 (___old_eval_frame)
              8 LOAD_GLOBAL              1 (___graph_fn_SIR_0)
             10 LOAD_FAST                0 (x)
             12 BUILD_TUPLE              1
             14 CALL_FUNCTION            1
             16 UNPACK_SEQUENCE          1
             18 STORE_FAST               3 (___SIR_out_var_1)
             20 LOAD_FAST                3 (___SIR_out_var_1)
             22 LOAD_GLOBAL              0 (paddle_set_eval_frame_fn)
             24 LOAD_FAST                2 (___old_eval_frame)
             26 CALL_FUNCTION            1
             28 POP_TOP
             30 RETURN_VALUE
Disassembly of <code object inner_function at 0x7f95ae8b58f0, file "/workspace/Paddle/build_310/test/sot/test_23_set_function_attribute.py", line 27>:
 28           0 LOAD_CONST               0 (None)
              2 RETURN_VALUE
[FallbackWrapper] start run SIR: 
 StatementIR: SIR_0
  inputs: ['var_0']
  outputs: ['var_1']
  statements: 
    method     || var_1 = __add__ (var_0) 
I1120 18:19:38.200965 18925 pir_interpreter.cc:1570] New Executor is Running ...
W1120 18:19:38.201596 18925 gpu_resources.cc:119] Please NOTE: device: 0, GPU Compute Capability: 7.0, Driver API Version: 12.3, Runtime API Version: 12.3
W1120 18:19:38.202356 18925 gpu_resources.cc:164] device: 0, cuDNN Version: 9.0.
I1120 18:19:38.202908 18925 pir_interpreter.cc:1591] pir interpreter is running by trace mode ...
---------------- PaddleSOT graph info ----------------
SubgraphNum: 1
OpNum: 4
---------------- PaddleSOT graph info ----------------
.
----------------------------------------------------------------------
Ran 1 test in 0.408s
OK

test/sot/test_24_to_bool.py

SigureMo · 2024-11-20T18:18:11Z

test/sot/test_22_make_function.py

22 和 23 这两个单测和现有的 test_13_make_function 的区别是？这里没必要添加新的文件吧？

test13没覆盖完，可以把这两个删了，然后改一下test13
因为涉及闭包会段错误，所以先不添加闭包的case

这个在其他版本没问题吧，那也应该加一下

python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py

SigureMo · 2024-11-20T18:23:23Z

关于闭包的段错误：

说明下复现方式，是哪个单测的哪个 case，命令贴一下

GoldenStain · 2024-11-20T18:49:21Z

段错误复现方式：

def make_fn(x: paddle.Tensor):
    def fn(a, b: int = 2, c: int = 3, *, d=4):
        y = x
        return a + b + c + d
    return fn(1) + fn(2, c=5) + x

在test_13当中，加入y = x形成闭包，就会触发段错误

python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py

test/sot/test_13_make_function.py

SigureMo · 2024-11-20T18:50:01Z

test/sot/test_22_make_function.py

这个在其他版本没问题吧，那也应该加一下

… sot

SigureMo

另外全量跑一下看看，是否有新的单测通过了？结果贴到 test/sot/skip_files_py313

python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py

… sot

SigureMo

其余 LGTM

python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py

SigureMo

LGTMeow

complete simulation process

56056d0

GoldenStain requested review from SigureMo, zrr1999 and gouzil as code owners November 20, 2024 18:11

paddle-bot bot added the contributor External developers label Nov 20, 2024

SigureMo reviewed Nov 20, 2024

View reviewed changes

fix bugs

b3ad888

SigureMo reviewed Nov 20, 2024

View reviewed changes

GoldenStain added 3 commits November 20, 2024 19:03

changed test

89a27a3

update test_13

6e4d122

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

b7dc517

… sot

SigureMo reviewed Nov 21, 2024

View reviewed changes

python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py Outdated Show resolved Hide resolved

python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py Outdated Show resolved Hide resolved

GoldenStain added 4 commits November 22, 2024 06:49

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

0e7103b

… sot

modified the logic in function related bytecodes

6e95694

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

dfd5bb9

… sot

update skip_files_py313

8f0af62

GoldenStain force-pushed the sot branch from 920e03c to 8f0af62 Compare November 22, 2024 09:01

SigureMo reviewed Nov 22, 2024

View reviewed changes

python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py Outdated Show resolved Hide resolved

Decoupling different bytecodes

5718a34

SigureMo approved these changes Nov 22, 2024

View reviewed changes

SigureMo mentioned this pull request Nov 22, 2024

SOT Python3.13 单测支持情况 #69246

Closed

SigureMo changed the title ~~[SOT][3.13]complete simulation for bytecode TO_BOOL MAKE_FUNCTION and SET_FUNCTION_ATTRIBUTE~~ [SOT][3.13] Complete simulation for bytecode TO_BOOL MAKE_FUNCTION and SET_FUNCTION_ATTRIBUTE Nov 22, 2024

SigureMo merged commit bf458f3 into PaddlePaddle:develop Nov 23, 2024
27 of 28 checks passed

SigureMo mentioned this pull request Nov 26, 2024

SOT Python3.13 支持任务汇总 #69245

Closed

GoldenStain deleted the sot branch March 19, 2025 13:55

[SOT][3.13] Complete simulation for bytecode TO_BOOL MAKE_FUNCTION and SET_FUNCTION_ATTRIBUTE #69567

[SOT][3.13] Complete simulation for bytecode TO_BOOL MAKE_FUNCTION and SET_FUNCTION_ATTRIBUTE #69567

Uh oh!

Conversation

GoldenStain commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Category

PR Types

Description

Uh oh!

paddle-bot bot commented Nov 20, 2024

Uh oh!

GoldenStain commented Nov 20, 2024

关于闭包的段错误：

3.13会发生段错误

3.10不会发生段错误

Uh oh!

Uh oh!

SigureMo Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

GoldenStain Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

SigureMo Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SigureMo commented Nov 20, 2024

Uh oh!

GoldenStain commented Nov 20, 2024

段错误复现方式：

Uh oh!

Uh oh!

Uh oh!

SigureMo Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

SigureMo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SigureMo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SigureMo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

[SOT][3.13] Complete simulation for bytecode `TO_BOOL` `MAKE_FUNCTION` and `SET_FUNCTION_ATTRIBUTE` #69567

[SOT][3.13] Complete simulation for bytecode `TO_BOOL` `MAKE_FUNCTION` and `SET_FUNCTION_ATTRIBUTE` #69567

GoldenStain commented Nov 20, 2024 •

edited

Loading