| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【SCU】【Paddle Tensor No.17、20】新增 paddle.inf, paddle.newaxis, 复用math.inf、None #69464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
|
python/paddle/__init__.py
Outdated
| @@ -771,6 +771,9 @@ | |||
| ir_guard = IrGuard() | |||
| ir_guard._switch_to_pir() | |||
|
|
|||
| from math import inf | |||
| newaxis: None=None | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| newaxis: None=None | |
| newaxis: None = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到
|
按照英文描述，签署一下CLA |
test/legacy_test/test_inf.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉这两个文件可以合并成：test_constant.py，然后其他同学的单测也写在这个文件里就行
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
python/paddle/__init__.py
Outdated
| @@ -771,6 +771,10 @@ | |||
| ir_guard = IrGuard() | |||
| ir_guard._switch_to_pir() | |||
|
|
|||
| from math import inf | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如非特殊理由，标准库统一在文件开头 import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到
| @@ -771,6 +771,10 @@ | |||
| ir_guard = IrGuard() | |||
| ir_guard._switch_to_pir() | |||
|
|
|||
| from math import inf | |||
|
|
|||
| newaxis: None = None | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| newaxis: None = None | |
| # Constants | |
| newaxis: None = None | |
| inf = math.inf |
前面不要 from math import inf，只使用 import math
将这些 constants 写在一起，后续方便管理
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Category
User Experience
PR Types
New features
Description
Paddle Tensor 规范化：新增 paddle.inf , paddle.newaxis，复用math.inf, None