You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed old indexing parsing code in Pybind and Python
For pybind code , since new indexing parsing for setitem and getitem was introduced in PR Move Dygraph Indexing Parsing to Pybind #58643 , it was no longer used in dygraph , will be removed.
For python code, it was remained before since there is no index_put kernel for xpu. With this kernel, we can unify the indexing code for these device, and remove the old code.
The unit test cases of test_set_value_op_xpu was modified, to keep it same to corresponding test_set_value_op .
你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-66985
Removed old indexing parsing code in Pybind and Python
For pybind code , since new indexing parsing for setitem and getitem was introduced in PR Move Dygraph Indexing Parsing to Pybind #58643 , it was no longer used in dygraph , will be removed.
For python code, it was remained before since there is no
index_put
kernel for xpu. With this kernel, we can unify the indexing code for these device, and remove the old code.The unit test cases of
test_set_value_op_xpu
was modified, to keep it same to correspondingtest_set_value_op
.