CARVIEW |
Select Language
HTTP/2 200
date: Mon, 28 Jul 2025 02:29:07 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=246.804687,conversation_content-fragment;desc="conversation_content fragment";dur=593.21057,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=316.811002,nginx;desc="NGINX";dur=1.062359,glb;desc="GLB";dur=101.167273
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=qqH4WxnMbFhCFSyYv2k2yJYgC%2F7QFZfxy95xzJk23YlrGNBqIicDve0NeSUK9jXBiRaczo4eKIS6Bv1k5XK5jX94K1tqnPmocakWrgXUe19pFCVZ%2B9rLKhGOtAdr9Q4Bcst5V3ug0nLfnx%2Fd%2Bf172QEqK2FHnfY42ynhpu7TwiqkAkOeZygkD5ZokDG5tVY3UKLsFhSYIJrZP6s%2BcfIUeEB4sVRI2asyqUFvGXThWhBY58FFonDK%2BEXBkvEyIRsQnbbpCRcQuKnuAY3XQ9meLQ%3D%3D--7Vzw8AIevduYjc%2Fu--cRTdyAI8vE95cP3ckZhImg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1987125690.1753669747; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 02:29:07 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 02:29:07 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D4A4:2E9E4D:66F05:9D497:6886E073
Delete Ref & VectorRef and add GetDataSafely by chenwhql · Pull Request #22997 · PaddlePaddle/Paddle · GitHub
chenwhql
changed the title
Delete invalid check inferface Ref & VectorRef
Delete Mar 31, 2020
chenwhql
changed the title
Delete
Delete Ref & VectorRef and add PADDLE_GET_DATA_SAFELY
Mar 31, 2020
chenwhql
changed the title
Delete Ref & VectorRef and add PADDLE_GET_DATA_SAFELY
Delete Ref & VectorRef and add PADDLE GET DATA SAFELY
Mar 31, 2020
chenwhql
changed the title
Delete Ref & VectorRef and add PADDLE GET DATA SAFELY
Delete Ref & VectorRef and add GetDataSafely
Mar 31, 2020
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Delete Ref & VectorRef and add GetDataSafely #22997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chenwhql
merged 10 commits into
PaddlePaddle:develop
from
chenwhql:easyuse/del_ref_vectorref
Apr 4, 2020
Merged
Delete Ref & VectorRef and add GetDataSafely #22997
chenwhql
merged 10 commits into
PaddlePaddle:develop
from
chenwhql:easyuse/del_ref_vectorref
Apr 4, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref & VectorRef
and add PADDLE_GET_DATA_SAFELY
Ref & VectorRef
and add PADDLE_GET_DATA_SAFELY
luotao1
approved these changes
Apr 4, 2020
sneaxiy
approved these changes
Apr 4, 2020
raindrops2sea
approved these changes
Apr 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mapingshuo
pushed a commit
to mapingshuo/Paddle
that referenced
this pull request
Apr 7, 2020
* delete invalid check inferface Ref & VectorRef, test=develop * fix vector ref delete error, test=develop * try the new check inferface, test=develop * change all related code with new check macro, test=develop * remove static assert, test=develop * polish detail, test=develop * skip coverage problem, test=develop * add new check macro, test=develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR revome two invalid error check interface, and add a valid error check interface:
not change the code logic, only enhances the error message
Remove
Ref & VectorRef
check (remove safe_ref.h)Ref & VectorRef
are used to safely obtain the data pointed to by a pointer. Before* ptr
, they will check whether the pointer isnullptr
. but...Ref & VectorRef
cannot tell users the actual error pointerRef & VectorRef
cannot tell users the actual error file & line numberexample:
a
, notptr
!enforce_test.cc:369
, notsafe_ref.h:28
!Add
GET_DATA_SAFELY
enforce.h
to replaceRef & VectorRef
, resolve all above problems!GET_DATA_SAFELY
macro, and pass in 3 key word, you can get a complete and accurate error message