Fix some typos (connot, transpsoe, etc.) (#61757)

co63oc · web-flow · commit dbaebcfba0c0 · 2024-02-19T17:40:59.000+08:00
diff --git a/paddle/cinn/frontend/pass/transpose_collapsing.cc b/paddle/cinn/frontend/pass/transpose_collapsing.cc
@@ -202,19 +202,19 @@ class TransposeCollapsingPass : public ProgramPass {
       if (can_remove) {
         VLOG(4) << "The transpose op {input[" << input_name << "], output["
                 << output_name << "], axis[" << cinn::utils::Join(axis, ",")
-                << "]} is a output op of graph, connot fuse, remove.";
+                << "]} is a output op of graph, cannot fuse, remove.";
         // this transpose not used by any other op, remove
         remove_instrs->insert(transpose);
       } else {
         if (CheckTransposeUseless(axis)) {
           VLOG(4) << "The transpose op {input[" << input_name << "], output["
                   << output_name << "], axis[" << cinn::utils::Join(axis, ",")
                   << "]} is fetched but useless, replace with identity.";
-          // cannot remove, however, the transpsoe is useless, we can replace
-          // the transpose with indentiy for more fusion opportunity
+          // cannot remove, however, the transpose is useless, we can replace
+          // the transpose with identity for more fusion opportunity
           ReplaceWithIdentity(transpose);
         }
-        // else the transpsoe is fetched and helpful, ignore
+        // else the transpose is fetched and helpful, ignore
       }
       return;
     }
@@ -226,7 +226,7 @@ class TransposeCollapsingPass : public ProgramPass {
         VLOG(4) << "The transpose op {input[" << input_name << "], output["
                 << output_name << "], axis[" << cinn::utils::Join(axis, ",")
                 << "]} is useless but fetched, replace with identity.";
-        // cannot remove, but we can replace the transpose with indentiy for
+        // cannot remove, but we can replace the transpose with identity for
         // more fusion opportunity
         ReplaceWithIdentity(transpose);
       } else {
diff --git a/paddle/cinn/frontend/syntax.cc b/paddle/cinn/frontend/syntax.cc
@@ -178,8 +178,8 @@ Variable Program::fused_meta_batchnorm_inference(
   CHECK(!scale->shape.empty()) << "scale's shape is empty.";
   auto broadcast_eps = primitive_broadcast_to(eps_var, scale->shape, {0});
   auto var_add_eps = add(variance, broadcast_eps);
-  auto rsrqt_var = primitive_rsqrt(var_add_eps);
-  auto new_scale = multiply(rsrqt_var, scale);
+  auto rsqrt_var = primitive_rsqrt(var_add_eps);
+  auto new_scale = multiply(rsqrt_var, scale);
   auto neg_mean = primitive_negative(mean);
   auto new_shift = multiply(new_scale, neg_mean);
   auto shift_bias = add(new_shift, bias);
@@ -207,8 +207,8 @@ Variable Program::fused_batchnorm_inference(
       primitive_const_scalar<float>(epsilon, cinn::common::UniqName("epsilon"));
   CHECK(!scale->shape.empty()) << "scale's shape is empty.";
   auto var_add_eps = elementwise_add(variance, eps_var);
-  auto rsrqt_var = primitive_rsqrt(var_add_eps);
-  auto new_scale = elementwise_mul(rsrqt_var, scale);
+  auto rsqrt_var = primitive_rsqrt(var_add_eps);
+  auto new_scale = elementwise_mul(rsqrt_var, scale);
   auto neg_mean = primitive_negative(mean);
   auto new_shift = elementwise_mul(new_scale, neg_mean);
   auto shift_bias = elementwise_add(new_shift, bias);
diff --git a/paddle/cinn/frontend/syntax.h b/paddle/cinn/frontend/syntax.h
@@ -410,7 +410,7 @@ struct Program {
 
   /**
    * Apply Rectified Linear Unit on input Variable.
-   * Actually apply: outupt = max(input,0)
+   * Actually apply: output = max(input,0)
    *
    * @param a The first variable.
    * @return The result.
diff --git a/paddle/cinn/hlir/dialect/operator/transforms/group_merge/generate_shape_util.cc b/paddle/cinn/hlir/dialect/operator/transforms/group_merge/generate_shape_util.cc
@@ -128,12 +128,12 @@ bool MoveGenerateShapeOpsToPrologue(
     pir::IrContext* ir_context,
     pir::Block* block,
     const ShapeOrDataDimExprsAccessor& dim_exprs_accessor) {
-  bool rewrited = false;
+  bool rewritten = false;
   while (RewriteOneGenerateShapeOpToRunFirst(
       ir_context, block, dim_exprs_accessor)) {
-    rewrited = true;
+    rewritten = true;
   }
-  return rewrited;
+  return rewritten;
 }
 
 }  // namespace cinn::dialect
diff --git a/paddle/cinn/hlir/dialect/operator/transforms/group_merge/generate_shape_util.h b/paddle/cinn/hlir/dialect/operator/transforms/group_merge/generate_shape_util.h
@@ -35,7 +35,7 @@ struct ShapeOrDataDimExprsAccessor {
       SetShapeOrDataDimExprs;
 };
 
-// Returns true if at least one GenerateShapeOp rewrited.
+// Returns true if at least one GenerateShapeOp rewrote.
 bool MoveGenerateShapeOpsToPrologue(
     pir::IrContext* ir_context,
     pir::Block* block,
diff --git a/paddle/cinn/hlir/dialect/operator/transforms/group_merge/group_with_group_merge_pass.cc b/paddle/cinn/hlir/dialect/operator/transforms/group_merge/group_with_group_merge_pass.cc
@@ -599,7 +599,7 @@ class DefaultInputFusePass final : public InputFusePass {
         break;
       }
 
-      // if can't fuse to othors Groups, new Groups.
+      // if can't fuse to other Groups, new Groups.
       if (!fusionable) {
         fusionable_consumers.push_back({candidate});
       }
@@ -690,7 +690,7 @@ class DefaultHorizontalFusePass final : public HorizontalFusePass {
         break;
       }
 
-      // if can't fuse to othors Groups, new Groups.
+      // if can't fuse to other Groups, new Groups.
       if (!fusionable) {
         fusionable_consumers.push_back({candidate});
       }
@@ -1114,7 +1114,7 @@ class GeneralFusionMergePassHelper {
   }
 
   GroupList operator()() {
-    // run fusion merge untill no update.
+    // run fusion merge until no update.
     DoFusionMerge();
     for (auto& group : fusion_groups_) {
       VLOG(3) << "Fusion Group -> " << group->group_id;
@@ -1658,7 +1658,7 @@ class GeneralFusionMergePassHelper {
                         fusionable_consumers) {
     VLOG(3) << "VerticalFuse...!";
     GroupList fused_groups;
-    GroupPtr master_fuesd_group(nullptr);
+    GroupPtr master_fused_group(nullptr);
     for (auto& consumer : fusionable_consumers) {
       auto fused_group = std::make_shared<ir::Group>();
       // update depth using consumer depth.
@@ -1800,8 +1800,8 @@ class GeneralFusionMergePassHelper {
       fusion_groups_[postion] = fused_group;
       fusion_groups_index_[fused_group] = postion;
 
-      if (!master_fuesd_group.get()) {
-        master_fuesd_group = fused_group;
+      if (!master_fused_group.get()) {
+        master_fused_group = fused_group;
       }
       CHECK(fused_group->output_ops.size())
           << "No output node is found, " << fused_group->group_id;
@@ -1831,19 +1831,19 @@ class GeneralFusionMergePassHelper {
 
       if (be_output) {
         // VLOG(4) << "Insert Id " << node->id() << " Into Group "
-        //         << master_fuesd_group->group_id;
-        master_fuesd_group->output_ops.insert(node);
+        //         << master_fused_group->group_id;
+        master_fused_group->output_ops.insert(node);
       }
     }
     // insert unfusionable consumer groups
     for (auto& consumer : *producer->mut_consumer_groups()) {
       if (fusionable_consumers.count(consumer)) {
         continue;
       }
-      master_fuesd_group->mut_consumer_groups()->insert(consumer);
+      master_fused_group->mut_consumer_groups()->insert(consumer);
       // update consumer's producer
       consumer->mut_producer_groups()->erase(producer);
-      consumer->mut_producer_groups()->insert(master_fuesd_group);
+      consumer->mut_producer_groups()->insert(master_fused_group);
     }
   }
 
@@ -1936,7 +1936,7 @@ class GeneralFusionMergePassHelper {
           sub_group->ops.insert(sub_group->ops.begin(),
                                 producer->CollectOps()[0]);
           sub_group->ops_set.insert(producer->CollectOps()[0]);
-          // remove depency.
+          // remove dependency.
           consumer->input_ops.erase(producer->CollectOps()[0]);
           consumer->mut_producer_groups()->erase(producer);
           producer->mut_consumer_groups()->erase(consumer);
diff --git a/paddle/cinn/hlir/dialect/operator/transforms/group_merge/group_with_group_merge_util.h b/paddle/cinn/hlir/dialect/operator/transforms/group_merge/group_with_group_merge_util.h
@@ -510,7 +510,7 @@ inline bool reduce_fuse_broadcast(const std::shared_ptr<ir::Group>& first,
 
       // auto broadcast_axes = absl::get<std::vector<int>>(
       //     broadcaster->attrs.attr_store.at("broadcast_axes"));
-      // TODO(phlrain) : suport here
+      // TODO(phlrain) : support here
       std::vector<int64_t> broadcaster_output_shape =
           GetVectorAttr(broadcaster, "out_shape");
       std::vector<int64_t> broadcast_axes =
diff --git a/paddle/cinn/hlir/dialect/operator/transforms/group_merge/special_ops_fusion_rule.cc b/paddle/cinn/hlir/dialect/operator/transforms/group_merge/special_ops_fusion_rule.cc
@@ -22,15 +22,15 @@ namespace cinn {
 namespace dialect {
 namespace ir {
 
-bool GatherNdFusionFule(const ::pir::Operation* consumer,
+bool GatherNdFusionRule(const ::pir::Operation* consumer,
                         OpPatternKind producer_group_pattern) {
   if (producer_group_pattern == OpPatternKind::kReduction) {
     return false;
   }
   return true;
 }
 
-bool SliceFusionFule(const ::pir::Operation* consumer,
+bool SliceFusionRule(const ::pir::Operation* consumer,
                      OpPatternKind producer_group_pattern) {
   if (producer_group_pattern == OpPatternKind::kReduction) {
     return false;
@@ -40,8 +40,8 @@ bool SliceFusionFule(const ::pir::Operation* consumer,
 
 void SpecialOpsFusionRule::Init() {
   RegisterConsumerOpRule(paddle::dialect::GatherNdOp::name(),
-                         &GatherNdFusionFule);
-  RegisterConsumerOpRule(cinn::dialect::SliceOp::name(), &SliceFusionFule);
+                         &GatherNdFusionRule);
+  RegisterConsumerOpRule(cinn::dialect::SliceOp::name(), &SliceFusionRule);
 }
 
 }  // namespace ir
diff --git a/paddle/cinn/hlir/framework/buffer.h b/paddle/cinn/hlir/framework/buffer.h
@@ -36,7 +36,7 @@ struct Buffer final {
   Buffer() = default;
   explicit Buffer(const cinn::common::Target& target) { SetTarget(target); }
   ~Buffer() { Free(); }
-  //! Resize the memory hold by this buffer *exactlly* to \p size.
+  //! Resize the memory hold by this buffer *exactly* to \p size.
   void Resize(uint32_t size);
   void Resize(uint32_t alignment, uint32_t size);
 
diff --git a/paddle/cinn/hlir/framework/graph_compiler_test.cc b/paddle/cinn/hlir/framework/graph_compiler_test.cc
@@ -33,7 +33,7 @@ namespace framework {
 using cinn::common::Float;
 using frontend::Placeholder;
 
-TEST(GraphCompilerTest, TestRemoveInvaildVariables) {
+TEST(GraphCompilerTest, TestRemoveInvalidVariables) {
   frontend::NetBuilder builder("test");
   auto a = builder.CreateInput(Float(32), {1, 64, 112, 112}, "A");
   auto b = builder.CreateInput(Float(32), {64}, "B");
diff --git a/paddle/cinn/hlir/framework/pir/op_lowering_impl.h b/paddle/cinn/hlir/framework/pir/op_lowering_impl.h
@@ -31,7 +31,7 @@
 
 // Fusion Op lowering, there are four kinds of lowering function:
 // Elementwise/Broadcast/Injective,Reduce,OutEWiseFusable,NonFusible.
-// Elementwise/Broadcast/Injective Ops is with same shcedule.
+// Elementwise/Broadcast/Injective Ops is with same schedule.
 // Reduce,OutEWiseFusable,NonFusible are using different schedule.
 
 namespace cinn {
diff --git a/paddle/cinn/hlir/framework/pir/op_lowering_util.cc b/paddle/cinn/hlir/framework/pir/op_lowering_util.cc
@@ -448,7 +448,7 @@ ::pir::Operation* GetMasterToComputeAt(
         done_schedule.insert(tmp);
       }
     }
-    // remove all consuemr reducer node of node from done_schedule.
+    // remove all consumer reducer node of node from done_schedule.
     std::unordered_set<::pir::Operation*> visited;
     std::queue<::pir::Operation*> candidates;
     candidates.push(op);
diff --git a/paddle/cinn/hlir/framework/pir/op_mapper.cc b/paddle/cinn/hlir/framework/pir/op_mapper.cc
@@ -73,8 +73,8 @@ void AppendAttrForUniformOp(const ::pir::Operation& op,
   attrs["dtype"] = "float32";
 }
 
-void AppendAttrForBoadcastToOp(const ::pir::Operation& op,
-                               utils::AttributeMap& attrs) {  // NOLINT
+void AppendAttrForBroadcastToOp(const ::pir::Operation& op,
+                                utils::AttributeMap& attrs) {  // NOLINT
   auto axes_attr = op.attributes().at("broadcast_axes");
   attrs["broadcast_axes"] = GetVec32FromVec64Attr(axes_attr);
 
@@ -121,7 +121,7 @@ void OpMapper::RegisterMapRules() {
   REGISTER_OPERAND_RULE(ProdOp, 0);
   REGISTER_ATTR_RULE(ReduceMaxOp, AppendAttrForReduceOp);
   REGISTER_ATTR_RULE(ReduceSumOp, AppendAttrForReduceOp);
-  REGISTER_ATTR_RULE(BroadcastOp, AppendAttrForBoadcastToOp);
+  REGISTER_ATTR_RULE(BroadcastOp, AppendAttrForBroadcastToOp);
   REGISTER_ATTR_RULE(UniformRandomOp, AppendAttrForUniformOp);
   REGISTER_PD_ATTR_RULE(TransposeOp, AppendAttrForTransposeOp);
   REGISTER_ATTR_RULE(SliceOp, AppendAttrForSliceOp);
diff --git a/paddle/cinn/hlir/framework/pir/op_mapper.h b/paddle/cinn/hlir/framework/pir/op_mapper.h
@@ -50,10 +50,10 @@ class OpMapper {
     return false;
   }
 
-  std::vector<::pir::Value> RealOprandSources(
+  std::vector<::pir::Value> RealOperandSources(
       const ::pir::Operation& op) const {
     CHECK(has(op, MapperType::OPERAND))
-        << "Not register OprandIndexsFunction for " << op.name();
+        << "Not register OperandIndexsFunction for " << op.name();
     std::vector<::pir::Value> inputs;
     for (auto idx : operand_funcs_.at(op.name())()) {
       inputs.push_back(op.operand_source(idx));
diff --git a/paddle/cinn/hlir/framework/pir/utils.cc b/paddle/cinn/hlir/framework/pir/utils.cc
@@ -276,7 +276,7 @@ std::string CompatibleInfo::ValueName(const ::pir::Value& value) {
 std::vector<::pir::Value> CompatibleInfo::RealOperandSources(
     const ::pir::Operation& op) {
   if (OpMapper::Instance().has(op, MapperType::OPERAND)) {
-    return OpMapper::Instance().RealOprandSources(op);
+    return OpMapper::Instance().RealOperandSources(op);
   } else {
     return op.operands_source();
   }

Original file line number	Diff line number	Diff line change
`@@ -410,7 +410,7 @@ struct Program {`
`410`	`410`
`411`	`411`	`/**`
`412`	`412`	`* Apply Rectified Linear Unit on input Variable.`
`413`		`- * Actually apply: outupt = max(input,0)`
	`413`	`+ * Actually apply: output = max(input,0)`
`414`	`414`	`*`
`415`	`415`	`* @param a The first variable.`
`416`	`416`	`* @return The result.`