[clang-tidy] NO.21 enable performance-for-range-copy (#61712)

enkilee · web-flow · commit da3c16e5c6bf · 2024-02-21T14:59:29.000+08:00
* clangtidy 21

* fix
diff --git a/paddle/fluid/framework/ir/mkldnn/cpu_quantize_pass_tester.cc b/paddle/fluid/framework/ir/mkldnn/cpu_quantize_pass_tester.cc
@@ -754,7 +754,7 @@ const std::vector<std::string> churn_out_vars(ProgramDesc* prog,
 
 void create_vars(ProgramDesc* prog,
                  const std::initializer_list<std::string>& names) {
-  for (auto name : names) prog->MutableBlock(0)->Var(name);
+  for (auto const& name : names) prog->MutableBlock(0)->Var(name);
 }
 
 void SetMultiGruOp(ProgramDesc* prog,
diff --git a/paddle/fluid/framework/ir/quantize_helper.cc b/paddle/fluid/framework/ir/quantize_helper.cc
@@ -38,7 +38,7 @@ std::unordered_map<std::string, std::vector<float>> GetQuantInfoFromTheGraph(
   const std::string suffix = "_" + key_suffix + "_" + flag;
   if (graph->Has(flag)) {
     std::vector<std::string> attr_names = graph->AttrNames();
-    for (auto fake_name : attr_names) {
+    for (auto const& fake_name : attr_names) {
       size_t pos = fake_name.find(suffix);
       if (pos != std::string::npos) {
         std::string name = fake_name.substr(0, pos);
diff --git a/paddle/fluid/framework/new_executor/interpreter/plan.cc b/paddle/fluid/framework/new_executor/interpreter/plan.cc
@@ -69,7 +69,7 @@ const std::vector<std::shared_ptr<Job>>& Plan::JobList() const {
 const std::vector<std::string> Plan::JobTypes() const {
   std::vector<std::string> res;
   res.reserve(type_to_program_.size());
-  for (auto kv : type_to_ir_program_) {
+  for (auto const& kv : type_to_ir_program_) {
     res.emplace_back(kv.first);
   }
   return res;
diff --git a/paddle/fluid/pir/transforms/inplace_pass.cc b/paddle/fluid/pir/transforms/inplace_pass.cc
@@ -451,7 +451,7 @@ std::unordered_map<pir::Operation*, std::string> GetInplaceOps(
     }
   }
   if (!FLAGS_ir_inplace_kernel_blacklist.empty()) {
-    for (auto i : inplace_ops) {
+    for (auto const& i : inplace_ops) {
       std::cout << i.second << std::endl;
     }
   }
diff --git a/paddle/fluid/platform/profiler/dump/serialization_logger.cc b/paddle/fluid/platform/profiler/dump/serialization_logger.cc
@@ -198,7 +198,7 @@ void SerializationLogger::LogHostTraceEventNode(
       OperatorSupplementEventProto::input_shape_proto::shape_vector*
           shape_vectors_proto = input_shape_proto->add_shape_vecs();
       auto shape_vectors = item.second;
-      for (auto shape_vector : shape_vectors) {
+      for (auto const& shape_vector : shape_vectors) {
         OperatorSupplementEventProto::input_shape_proto::shape_vector::shape*
             shape_proto = shape_vectors_proto->add_shapes();
         for (auto& shape_item : shape_vector) {
diff --git a/paddle/phi/kernels/funcs/jit/test.cc b/paddle/phi/kernels/funcs/jit/test.cc
@@ -75,7 +75,7 @@ void TestAllImpls(const typename KernelTuple::attr_type& attr,
                   const Tester& verifier,
                   const Args&... args) {
   auto funcs = jit::GetAllCandidateFuncsWithTypes<KernelTuple, PlaceType>(attr);
-  for (auto f : funcs) {
+  for (auto const& f : funcs) {
     VLOG(10) << "Test Kernel " << f.first;
     verifier(f.second, args...);
   }
diff --git a/paddle/testing/paddle_gtest_main.cc b/paddle/testing/paddle_gtest_main.cc
@@ -50,7 +50,7 @@ int main(int argc, char** argv) {  // NOLINT
   char* env_str = nullptr;
   if (!envs.empty()) {
     std::string env_string = "--tryfromenv=";
-    for (auto t : envs) {
+    for (auto const& t : envs) {
       env_string += t + ",";
     }
     env_string = env_string.substr(0, env_string.length() - 1);
diff --git a/test/cpp/fluid/framework/prune_test.cc b/test/cpp/fluid/framework/prune_test.cc
@@ -30,8 +30,8 @@ void AddOp(const std::string &type,
            f::AttributeMap attrs,
            paddle::framework::BlockDesc *block) {
   // insert output
-  for (auto kv : outputs) {
-    for (auto v : kv.second) {
+  for (auto const &kv : outputs) {
+    for (auto const &v : kv.second) {
       auto var = block->Var(v);
       var->SetDataType(paddle::framework::proto::VarType::FP32);
     }
diff --git a/test/cpp/fluid/reader/reader_blocking_queue_test.cc b/test/cpp/fluid/reader/reader_blocking_queue_test.cc
@@ -117,12 +117,12 @@ void CheckIsUnorderedSame(const std::vector<std::vector<size_t>>& v1,
                           const std::vector<std::vector<size_t>>& v2) {
   std::set<size_t> s1;
   std::set<size_t> s2;
-  for (auto vec : v1) {
+  for (auto const& vec : v1) {
     for (size_t elem : vec) {
       s1.insert(elem);
     }
   }
-  for (auto vec : v2) {
+  for (auto const& vec : v2) {
     for (size_t elem : vec) {
       s2.insert(elem);
     }
diff --git a/test/cpp/inference/api/api_tester.cc b/test/cpp/inference/api/api_tester.cc
@@ -95,7 +95,7 @@ TEST(paddle_inference_api, AnalysisConfigCopyCtor) {
   AnalysisConfig cfg2(cfg1);
 
   auto passes = cfg2.pass_builder()->AllPasses();
-  for (auto ps : passes) {
+  for (auto const &ps : passes) {
     CHECK_NE(ps, delete_pass);
   }
 }
diff --git a/test/cpp/utils/string/split_test.cc b/test/cpp/utils/string/split_test.cc
@@ -21,7 +21,7 @@
 TEST(StringSplit, StringSplit) {
   std::string to_split = "0,1,2,3,4,5";
   int i = 0;
-  for (auto s : paddle::string::Split(to_split, ',')) {
+  for (auto const& s : paddle::string::Split(to_split, ',')) {
     EXPECT_EQ(atoi(s.c_str()), i);
     i++;
   }

Original file line number	Diff line number	Diff line change
`@@ -754,7 +754,7 @@ const std::vector<std::string> churn_out_vars(ProgramDesc* prog,`
`754`	`754`
`755`	`755`	`void create_vars(ProgramDesc* prog,`
`756`	`756`	`const std::initializer_list<std::string>& names) {`
`757`		`- for (auto name : names) prog->MutableBlock(0)->Var(name);`
	`757`	`+ for (auto const& name : names) prog->MutableBlock(0)->Var(name);`
`758`	`758`	`}`
`759`	`759`
`760`	`760`	`void SetMultiGruOp(ProgramDesc* prog,`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ const std::vector<std::shared_ptr<Job>>& Plan::JobList() const {`
`69`	`69`	`const std::vector<std::string> Plan::JobTypes() const {`
`70`	`70`	`std::vector<std::string> res;`
`71`	`71`	`res.reserve(type_to_program_.size());`
`72`		`- for (auto kv : type_to_ir_program_) {`
	`72`	`+ for (auto const& kv : type_to_ir_program_) {`
`73`	`73`	`res.emplace_back(kv.first);`
`74`	`74`	`}`
`75`	`75`	`return res;`
Original file line number	Diff line number	Diff line change
`@@ -451,7 +451,7 @@ std::unordered_map<pir::Operation*, std::string> GetInplaceOps(`
`451`	`451`	`}`
`452`	`452`	`}`
`453`	`453`	`if (!FLAGS_ir_inplace_kernel_blacklist.empty()) {`
`454`		`- for (auto i : inplace_ops) {`
	`454`	`+ for (auto const& i : inplace_ops) {`
`455`	`455`	`std::cout << i.second << std::endl;`
`456`	`456`	`}`
`457`	`457`	`}`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ void TestAllImpls(const typename KernelTuple::attr_type& attr,`
`75`	`75`	`const Tester& verifier,`
`76`	`76`	`const Args&... args) {`
`77`	`77`	`auto funcs = jit::GetAllCandidateFuncsWithTypes<KernelTuple, PlaceType>(attr);`
`78`		`- for (auto f : funcs) {`
	`78`	`+ for (auto const& f : funcs) {`
`79`	`79`	`VLOG(10) << "Test Kernel " << f.first;`
`80`	`80`	`verifier(f.second, args...);`
`81`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ int main(int argc, char** argv) { // NOLINT`
`50`	`50`	`char* env_str = nullptr;`
`51`	`51`	`if (!envs.empty()) {`
`52`	`52`	`std::string env_string = "--tryfromenv=";`
`53`		`- for (auto t : envs) {`
	`53`	`+ for (auto const& t : envs) {`
`54`	`54`	`env_string += t + ",";`
`55`	`55`	`}`
`56`	`56`	`env_string = env_string.substr(0, env_string.length() - 1);`
Original file line number	Diff line number	Diff line change
`@@ -117,12 +117,12 @@ void CheckIsUnorderedSame(const std::vector<std::vector<size_t>>& v1,`
`117`	`117`	`const std::vector<std::vector<size_t>>& v2) {`
`118`	`118`	`std::set<size_t> s1;`
`119`	`119`	`std::set<size_t> s2;`
`120`		`- for (auto vec : v1) {`
	`120`	`+ for (auto const& vec : v1) {`
`121`	`121`	`for (size_t elem : vec) {`
`122`	`122`	`s1.insert(elem);`
`123`	`123`	`}`
`124`	`124`	`}`
`125`		`- for (auto vec : v2) {`
	`125`	`+ for (auto const& vec : v2) {`
`126`	`126`	`for (size_t elem : vec) {`
`127`	`127`	`s2.insert(elem);`
`128`	`128`	`}`
Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ TEST(paddle_inference_api, AnalysisConfigCopyCtor) {`
`95`	`95`	`AnalysisConfig cfg2(cfg1);`
`96`	`96`
`97`	`97`	`auto passes = cfg2.pass_builder()->AllPasses();`
`98`		`- for (auto ps : passes) {`
	`98`	`+ for (auto const &ps : passes) {`
`99`	`99`	`CHECK_NE(ps, delete_pass);`
`100`	`100`	`}`
`101`	`101`	`}`