CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 08:34:51 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/911
server-timing: nginx;desc="NGINX";dur=1.075935,glb;desc="GLB";dur=97.441915
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=LKbWEAhW5S5oNocbekC64%2B7C1tf72%2BjrRleDlEjIAZEGdwv%2B533sh9CG34qVk1YhtYes%2Bkjda3FhxozgMXoPoKzRH5HFN8c%2FM9x%2FSleDniizT7yQ4iijcC3icrqBlPzqjdZU4rH3p0vN%2FuoaGzhc6fOEZRzmE4DBLidyqdmxa6zwyVuTsy22wWURmzB7n8KvIct4PXUof7LvM%2F5gm0YSrnvewGFW2bPrb8E2uC6ym8mY2R6maaKdz7qBQwjasHwr5c6tfhbkzMR13NEKL2daWg%3D%3D--II3ksxVqLwl4OzEk--VraR5zPESzi2P1mYgy7zfw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1638055089.1752568491; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 08:34:51 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 08:34:51 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8128:37FF58:48655B:522088:687612AB
HTTP/2 200
date: Tue, 15 Jul 2025 08:34:52 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=414.88354,conversation_content-fragment;desc="conversation_content fragment";dur=546.866594,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=304.893634,nginx;desc="NGINX";dur=0.905129,glb;desc="GLB";dur=96.63022
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 8128:37FF58:48660C:522102:687612AB
Exclude EDE before other EDNS options when there isn't enough space by natalie-reece · Pull Request #911 · NLnetLabs/unbound · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 397
Exclude EDE before other EDNS options when there isn't enough space #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gthess
added a commit
that referenced
this pull request
Aug 1, 2023
altogether) before giving up on attaching EDE options.
gthess
added a commit
that referenced
this pull request
Aug 1, 2023
…s when there isn't enough space. - For #911: Try to trim EXTRA-TEXT (and LDNS_EDE_OTHER options altogether) before giving up on attaching EDE options.
Thanks for this! |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Aug 11, 2023
* nlnet/master: (52 commits) - Move a cache reply callback in worker.c closer to the cache reply generation. - Fix to use the now cached EDE, if any, for CD_bit queries. - More braces and formatting for Fix for EDNS EDE size calculation to avoid future bugs. - Fix for EDNS EDE size calculation. - For NLnetLabs#911: Try to trim EXTRA-TEXT (and LDNS_EDE_OTHER options altogether) before giving up on attaching EDE options. - iana portlist update. - Merge NLnetLabs#790 from Tom Carpay: Add support for EDE caching in cachedb and subnetcache. - For NLnetLabs#790: Update formatting in cachedb/cachedb.c - For NLnetLabs#790: clean testcase. - For NLnetLabs#759: fix doc string. - Fix unused variable compile warning for kernel timestamps in netevent.c - Review for NLnetLabs#790: Fix memory leak. - Review for NLnetLabs#790: Address Wouter's comments. - Review for NLnetLabs#790: replace tdir tests with simpler rpl tests. Address review comments for NLnetLabs#759: - Clear error text when an expected signature is missing. Address review comments for NLnetLabs#759: - Decrease allocations for "" EDE strings when loading the cachedump. - Check for existence of EDE code before attaching. - For NLnetLabs#889: Account for num_detached_states before possible mesh_state_delete when erroring out. - For NLnetLabs#889: use netcat-openbsd instead of netcat-traditional. - Cleaner failure code for callback functions in interface.i. Log established connection to Redis ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This change drops any EDE options from a response packet when there is not enough space for them but there is still enough space for the rest of the OPT record. This matches with the behavior specified in RFC 8914, which says "When the response grows beyond the requestor's UDP payload size, servers SHOULD truncate messages by dropping EDE options before dropping other data from packets".
In the function reply_info_answer_encode, I made the following changes:
In order to do this, I added a function calc_edns_option_size that calculates the size of an edns option. This function is similar to the existing function calc_edns_field_size, except it only finds the size for one option code.
The function error_encode was also changed so that if there is not enough space for all of the edns data, then any ede options are removed. Then, if there is enough space for the rest of the edns data, it is added, otherwise it is left out.