You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where a TCP session prevents one child to exit quickly, causing the others to become because of the blocking read waiting for QUIT_SYNC_ACK that old-main sends when all the old serve children have exited.
When processes take long to exit they exit after the "reload" process becomes "main" again. In server_main(), the loop starts with reaping exited children, and then a poll or ppoll starts waiting for 60 seconds. If old-main or old server childs took long to exit, they will exit during the 60 seconds poll en become . By changing the wait to 1 second, such processes are reaped at least once a second.
For the case when TCP session holds one server processes alive during a reload.
The others exit and become <defunct> because of a blocking read in
server_reload().
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, when a signal comes in during the reload change over ipc, then children are reaped by the reload process. This makes them immediately close down, instead of waiting.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles two processes causes